Spec URL: http://www.grid.tsl.uu.se/review/globus-gram-job-manager-callout-error.spec
SRPM URL: http://www.grid.tsl.uu.se/review/globus-gram-job-manager-callout-error-0.2-1.fc11.src.rpm
The Globus Toolkit is an open source software toolkit used for building Grid
systems and applications. It is being developed by the Globus Alliance and
many others all over the world. A growing number of projects and companies are
using the Globus Toolkit to unlock the potential of grids for their cause.
The globus-gram-job-manager-callout-error package contains:
Globus GRAM Jobmanager Callout Errors
Globus Toolkit Packaging Guidelines:
The end result of this huge number of packages is excellent but the
work the process to get to that point..... It's worth while for
sure. Liked the article.
Review of globus-gram-job-manager-callout-error
Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1750703
$ rpmlint globus-gram-job-manager-callout-error.spec ../SRPMS/globus-gram-job-manager-callout-error-0.2-1.fc11.src.rpm ../RPMS/x86_64/globus-gram-job-manager-callout-error-* ../RPMS/noarch/globus-gram-job-manager-callout-error-doc-0.2-1.fc11.noarch.rpm
globus-gram-job-manager-callout-error-debuginfo.x86_64: E: description-line-too-long This package provides debug information for package globus-gram-job-manager-callout-error.
globus-gram-job-manager-callout-error-devel.x86_64: W: no-documentation
5 packages and 1 specfiles checked; 1 errors, 1 warnings.
Just the trivial line to long but its easy to fix, presumably can
be added to your .spec generator.
YES: pkg name good.
YES: spec file name good.
YES: Meets globus guidelines.
YES: License in .spec file.
YES: Licesne files in package
YES: American English.
YES: Spec legible.
$ diff -r --brief globus_gram_job_manager_callout_error-0.2 ~/globus/src/gt4.2.1-all-source-installer/source-trees/gram/jobmanager/callout_error/
Only in globus_gram_job_manager_callout_error-0.2: GLOBUS_LICENSE
which is expected.
YES: Builds fine, see koji above.
YES: Builds on all
YES: BR good, in koji.
YES: No locales present.
YES: ldconfig called suitably.
YES: No system libs.
YES: Not relocatable.
YES: Owns directories or pulls them in.
YES: No double enties.
YES: All defattr.
YES: build root removed on clean.
YES: Consistant use of macros.
YES: Yes there is code if not a lot.
YES: %doc not needed runtime.
YES: devel package good.
YES: devel requires libs.
$ rpm -pq --requires globus-gram-job-manager-callout-error-devel-0.2-1.fc11.x86_64.rpm
globus-common-devel(x86-64) >= 3
globus-core(x86-64) >= 4
globus-gram-job-manager-callout-error(x86-64) = 0.2-1.fc11
YES: no .la files present.
YES: no gui.
Just the trivial description.
(In reply to comment #1)
> The end result of this huge number of packages is excellent but the
> work the process to get to that point..... It's worth while for
> sure. Liked the article.
> Just the trivial line to long but its easy to fix, presumably can
> be added to your .spec generator.
> Just the trivial description.
The discussion in bug 516516, comment 2 applies here as well.
Quoting the above reference:
"The definition of the description of the debuginfo package is not part if the specfile, but is defined in the %debug_info macro."
Comment #2 satisfies everything.
Many thanks for the review!
New Package CVS Request
Package Name: globus-gram-job-manager-callout-error
Short Description: Globus Toolkit - Globus GRAM Jobmanager Callout Errors
Branches: F-11 F-12 EL-4 EL-5
globus-gram-job-manager-callout-error-0.2-1.fc11 has been submitted as an update for Fedora 11.
globus-gram-job-manager-callout-error-0.2-1.el5 has been submitted as an update for Fedora EPEL 5.
globus-gram-job-manager-callout-error-0.2-1.el4 has been submitted as an update for Fedora EPEL 4.
globus-gram-job-manager-callout-error-0.2-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
globus-gram-job-manager-callout-error-0.2-1.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report.
globus-gram-job-manager-callout-error-0.2-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.