Bug 516535
| Summary: | Review Request: globus-gram-job-manager-scripts - Globus Toolkit - GRAM Job ManagerScripts | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mattias Ellert <mattias.ellert> |
| Component: | Package Review | Assignee: | Steve Traylen <steve.traylen> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | caius.chance, fedora-package-review, notting, steve.traylen |
| Target Milestone: | --- | Flags: | steve.traylen:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.7-1.el4 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-12-04 23:55:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 516527 | ||
| Bug Blocks: | 516536, 516537, 516538, 516539, 516540 | ||
|
Description
Mattias Ellert
2009-08-10 11:03:30 UTC
rpmlint is okay: $ rpmlint globus-gram-job-manager-scripts.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. Wny don't install documentation directly to default RPM location? FYI, mock is passed: INFO: Done(globus-gram-job-manager-scripts-0.7-1.fc11.src.rpm) Config(fedora-rawhide-i386) 1 minutes 47 seconds (In reply to comment #2) > Wny don't install documentation directly to default RPM location? There is no easy way to do that. It is not --docdir that is wrong w.r.t. the RPM location, it is the name of the subdirectory inside --docdir. There is no configure switch for that. All globus packages in Fedora do it this way. I noticed this about the documentation as well but decided it was sensible and a marked at %doc so fine. Caio 'kaio' Chance I'm going to review this in the next few days unless you have any more comments on the documentation? Steve (In reply to comment #5) > Caio 'kaio' Chance > > I'm going to review this in the next few days unless you have any more > comments on the documentation? > > Steve no thx http://koji.fedoraproject.org/koji/taskinfo?taskID=1825910 yes: rpmlint above. yes: package name. yes: spec file name yes: globus package guidelines. yes: ASL 2.0 in .SPEC yes: ASL 2.0 in reality. yes: GLOBUS_LICENSE file included. yes: english spec. yes: legible spec. yes: source matches upstream. yes: builds (fc13) yes: build requires sane. yes: buils on archs - see koji yes: no locaes. yes: no ldconfig needed. yes: no system libs. yes: not reloc' yes: no duplicates. yes: Package contains all directories it creates or pulls them. yes: everything %defatt yes: cleans everything. yes: macro use good. yes: contains code. yes: java doc in seperate package. yes: %doc not needed runtime. yes: no devel package. yes: no static libs. yes: no pkgconfig files. yes: no devel packages. yes: no .la files. yes: no gui. ?: Owns files from other packages. see below. yes: %install cleans itself. I notice quite a few packages seem to own /usr/lib/perl5/vendor_perl/5.10.0/Globus including this one. Steve yes: utf8. (In reply to comment #7) > ?: Owns files from other packages. > see below. > > I notice quite a few packages seem to own > > /usr/lib/perl5/vendor_perl/5.10.0/Globus > > including this one. This is necessary in order to comply to the Perl packaging guidelines: https://fedoraproject.org/wiki/Packaging/Perl#Directory_Ownership "As an example, assume that perl-A-B depends on perl-A and installs files into /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/A/B. The base Perl package guarantees that it will own /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi for as long as it remains compatible with version 5.10.0, but a future upgrade of the perl-A package may install into (and thus own) /usr/lib/perl5/vendor_perl/5.11.0/i386-linux-thread-multi/A. So the perl-A-B package needs to own /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/A as well as /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/A/B in order to maintain proper ownership." Agreed. APPROVED Thank you for the review! New Package CVS Request ======================= Package Name: globus-gram-job-manager-scripts Short Description: Globus Toolkit - GRAM Job ManagerScripts Owners: ellert Branches: F-11 F-12 EL-4 EL-5 InitialCC: cvs done. globus-gram-job-manager-scripts-0.7-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/globus-gram-job-manager-scripts-0.7-1.fc12 globus-gram-job-manager-scripts-0.7-1.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/globus-gram-job-manager-scripts-0.7-1.el4 globus-gram-job-manager-scripts-0.7-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/globus-gram-job-manager-scripts-0.7-1.fc11 globus-gram-job-manager-scripts-0.7-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. globus-gram-job-manager-scripts-0.7-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. globus-gram-job-manager-scripts-0.7-1.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report. |