Bug 516535 - Review Request: globus-gram-job-manager-scripts - Globus Toolkit - GRAM Job ManagerScripts
Summary: Review Request: globus-gram-job-manager-scripts - Globus Toolkit - GRAM Job M...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Steve Traylen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 516527
Blocks: 516536 516537 516538 516539 516540
TreeView+ depends on / blocked
 
Reported: 2009-08-10 11:03 UTC by Mattias Ellert
Modified: 2009-12-17 23:53 UTC (History)
4 users (show)

Fixed In Version: 0.7-1.el4
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-12-04 23:55:15 UTC
steve.traylen: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Mattias Ellert 2009-08-10 11:03:30 UTC
Spec URL: http://www.grid.tsl.uu.se/review/globus-gram-job-manager-scripts.spec
SRPM URL: http://www.grid.tsl.uu.se/review/globus-gram-job-manager-scripts-0.7-1.fc11.src.rpm

Description:
The Globus Toolkit is an open source software toolkit used for building Grid
systems and applications. It is being developed by the Globus Alliance and
many others all over the world. A growing number of projects and companies are
using the Globus Toolkit to unlock the potential of grids for their cause.

The globus-gram-job-manager-scripts package contains:
GRAM Job ManagerScripts

Globus Toolkit Packaging Guidelines:
https://fedoraproject.org/wiki/Packaging:Globus

Comment 1 caius.chance 2009-08-14 03:35:29 UTC
rpmlint is okay:

$ rpmlint globus-gram-job-manager-scripts.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 2 caius.chance 2009-08-14 03:47:34 UTC
Wny don't install documentation directly to default RPM location?

FYI, mock is passed:

INFO: Done(globus-gram-job-manager-scripts-0.7-1.fc11.src.rpm) Config(fedora-rawhide-i386) 1 minutes 47 seconds

Comment 3 Mattias Ellert 2009-08-14 06:38:57 UTC
(In reply to comment #2)
> Wny don't install documentation directly to default RPM location?

There is no easy way to do that. It is not --docdir that is wrong w.r.t. the RPM location, it is the name of the subdirectory inside --docdir. There is no configure switch for that. All globus packages in Fedora do it this way.

Comment 4 Steve Traylen 2009-10-16 20:51:47 UTC
I noticed this about the documentation as well but decided it was sensible and a 
marked at %doc so fine.

Comment 5 Steve Traylen 2009-11-17 20:35:27 UTC
  Caio 'kaio' Chance

I'm going to review this in the next few days unless you have any more
comments on the documentation?

Steve

Comment 6 caius.chance 2009-11-18 16:17:25 UTC
(In reply to comment #5)
>   Caio 'kaio' Chance
> 
> I'm going to review this in the next few days unless you have any more
> comments on the documentation?
> 
> Steve  

no thx

Comment 7 Steve Traylen 2009-11-23 21:08:00 UTC
http://koji.fedoraproject.org/koji/taskinfo?taskID=1825910

yes: rpmlint above.
yes: package name.
yes: spec file name
yes: globus package guidelines.
yes: ASL 2.0 in .SPEC
yes: ASL 2.0 in reality. 
yes: GLOBUS_LICENSE file included.
yes: english spec.
yes: legible spec.
yes: source matches upstream.
yes: builds (fc13)
yes: build requires sane.
yes: buils on archs - see koji
yes: no locaes.
yes: no ldconfig needed.
yes: no system libs.
yes: not reloc'
yes: no duplicates.
yes: Package contains all directories it creates or pulls them.
yes: everything %defatt
yes: cleans everything.
yes: macro use good.
yes: contains code.
yes: java doc in seperate package.
yes: %doc not needed runtime.
yes: no devel package.
yes: no static libs.
yes: no pkgconfig files.
yes: no devel packages.
yes: no .la files.
yes: no gui.
?: Owns files from other packages.
   see below.
yes: %install cleans itself.

I notice quite a few packages seem to own

/usr/lib/perl5/vendor_perl/5.10.0/Globus

including this one.

Steve


yes: utf8.

Comment 8 Mattias Ellert 2009-11-24 06:05:11 UTC
(In reply to comment #7)

> ?: Owns files from other packages.
>    see below.
> 
> I notice quite a few packages seem to own
> 
> /usr/lib/perl5/vendor_perl/5.10.0/Globus
> 
> including this one.

This is necessary in order to comply to the Perl packaging guidelines:

https://fedoraproject.org/wiki/Packaging/Perl#Directory_Ownership

"As an example, assume that perl-A-B depends on perl-A and installs files into /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/A/B. The base Perl package guarantees that it will own /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi for as long as it remains compatible with version 5.10.0, but a future upgrade of the perl-A package may install into (and thus own) /usr/lib/perl5/vendor_perl/5.11.0/i386-linux-thread-multi/A. So the perl-A-B package needs to own /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/A as well as /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/A/B in order to maintain proper ownership."

Comment 9 Steve Traylen 2009-11-24 07:51:34 UTC
Agreed.

APPROVED

Comment 10 Mattias Ellert 2009-11-24 11:55:22 UTC
Thank you for the review!

New Package CVS Request
=======================
Package Name: globus-gram-job-manager-scripts
Short Description: Globus Toolkit - GRAM Job ManagerScripts
Owners: ellert
Branches: F-11 F-12 EL-4 EL-5
InitialCC:

Comment 11 Kevin Fenzi 2009-11-27 05:39:32 UTC
cvs done.

Comment 12 Fedora Update System 2009-12-03 16:20:13 UTC
globus-gram-job-manager-scripts-0.7-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/globus-gram-job-manager-scripts-0.7-1.fc12

Comment 13 Fedora Update System 2009-12-03 16:20:14 UTC
globus-gram-job-manager-scripts-0.7-1.el4 has been submitted as an update for Fedora EPEL 4.
http://admin.fedoraproject.org/updates/globus-gram-job-manager-scripts-0.7-1.el4

Comment 14 Fedora Update System 2009-12-03 16:20:18 UTC
globus-gram-job-manager-scripts-0.7-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/globus-gram-job-manager-scripts-0.7-1.fc11

Comment 15 Fedora Update System 2009-12-04 23:55:09 UTC
globus-gram-job-manager-scripts-0.7-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2009-12-04 23:56:27 UTC
globus-gram-job-manager-scripts-0.7-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2009-12-17 23:53:28 UTC
globus-gram-job-manager-scripts-0.7-1.el4 has been pushed to the Fedora EPEL 4 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.