Bug 518219

Summary:	Review Request: dumbster - Fake SMTP Server
Product:	[Fedora] Fedora	Reporter:	Alexander Kurtakov <akurtako>
Component:	Package Review	Assignee:	Andrew Overholt <overholt>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, overholt
Target Milestone:	---	Flags:	overholt: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-08-20 17:22:25 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	429551

Description Alexander Kurtakov 2009-08-19 14:43:07 UTC

Spec URL: http://akurtakov.fedorapeople.org/dumbster.spec
SRPM URL: http://akurtakov.fedorapeople.org/dumbster-1.6-8.fc12.src.rpm
Description: The Dumbster is a very simple fake SMTP server designed for
unit and system testing applications that send email messages.
It responds to all standard SMTP commands but does not deliver
messages to the user. The messages are stored within the
Dumbster for later extraction and verification.

Comment 1 Alexander Kurtakov 2009-08-19 14:44:34 UTC

This is a full review request.  The pre-review request was bug #500251.

Comment 2 Andrew Overholt 2009-08-19 15:43:26 UTC

- change the groups to make rpmlint quiet
- md5sum of source doesn't match but contents do
- you can remove the post{,un} requirements for javadoc
- there are two sections to SimpleSmtpServer.java; I'd like to see the first one go upstream or at least be discussed with upstream.  I won't block on this.

Otherwise, things are good to go

Comment 3 Alexander Kurtakov 2009-08-20 12:01:37 UTC

(In reply to comment #2)
> - change the groups to make rpmlint quiet
Fixed.
> - md5sum of source doesn't match but contents do
I can't do anything about this.
> - you can remove the post{,un} requirements for javadoc
Fixed.
> - there are two sections to SimpleSmtpServer.java; I'd like to see the first
> one go upstream or at least be discussed with upstream.  I won't block on this.
> 
I'll consider sending a patch. But project looks pretty much dead.


Spec URL: http://akurtakov.fedorapeople.org/dumbster.spec
SRPM URL: http://akurtakov.fedorapeople.org/dumbster-1.6-9.fc12.src.rpm

Comment 4 Andrew Overholt 2009-08-20 14:24:35 UTC

I no longer get the javadoc issue.  Everything else looks good.  Approved.

Comment 5 Alexander Kurtakov 2009-08-20 17:22:25 UTC

Build in rawhide.
http://koji.fedoraproject.org/koji/buildinfo?buildID=128103