Spec URL: http://akurtakov.fedorapeople.org/dumbster.spec SRPM URL: http://akurtakov.fedorapeople.org/dumbster-1.6-8.fc12.src.rpm Description: The Dumbster is a very simple fake SMTP server designed for unit and system testing applications that send email messages. It responds to all standard SMTP commands but does not deliver messages to the user. The messages are stored within the Dumbster for later extraction and verification.
This is a full review request. The pre-review request was bug #500251.
- change the groups to make rpmlint quiet - md5sum of source doesn't match but contents do - you can remove the post{,un} requirements for javadoc - there are two sections to SimpleSmtpServer.java; I'd like to see the first one go upstream or at least be discussed with upstream. I won't block on this. Otherwise, things are good to go
(In reply to comment #2) > - change the groups to make rpmlint quiet Fixed. > - md5sum of source doesn't match but contents do I can't do anything about this. > - you can remove the post{,un} requirements for javadoc Fixed. > - there are two sections to SimpleSmtpServer.java; I'd like to see the first > one go upstream or at least be discussed with upstream. I won't block on this. > I'll consider sending a patch. But project looks pretty much dead. Spec URL: http://akurtakov.fedorapeople.org/dumbster.spec SRPM URL: http://akurtakov.fedorapeople.org/dumbster-1.6-9.fc12.src.rpm
I no longer get the javadoc issue. Everything else looks good. Approved.
Build in rawhide. http://koji.fedoraproject.org/koji/buildinfo?buildID=128103