Bug 518634
| Summary: | Review Request: plexus-digest - Plexus Digest / Hashcode Components | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alexander Kurtakov <akurtako> |
| Component: | Package Review | Assignee: | Andrew Overholt <overholt> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, overholt |
| Target Milestone: | --- | Flags: | overholt:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-08-21 19:11:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 429551 | ||
|
Description
Alexander Kurtakov
2009-08-21 11:46:41 UTC
This is a full review request. The pre-review request was bug #500249. X please make lines 126 and 144 <= 80 characters X please remove "ghost symlink" comment since it's no longer true X the license appears to be exclusively ASL 2.0; remove " and Plexus" OK sources match what I download OK rpmlint output acceptable: plexus-digest.noarch: W: no-documentation plexus-digest.noarch: W: non-conffile-in-etc /etc/maven/fragments/plexus-digest Ok naming, versioning OK files OK requires OK builds OK macros OK rm -rf at beginning of %install and %clean present (In reply to comment #2) > X please make lines 126 and 144 <= 80 characters Fixed > X please remove "ghost symlink" comment since it's no longer true Fixed. > X the license appears to be exclusively ASL 2.0; remove " and Plexus" Fixed. > > OK sources match what I download > OK rpmlint output acceptable: > plexus-digest.noarch: W: no-documentation > plexus-digest.noarch: W: non-conffile-in-etc > /etc/maven/fragments/plexus-digest > Ok naming, versioning > OK files > OK requires > OK builds > OK macros > OK rm -rf at beginning of %install and %clean present New sources: Spec URL: http://akurtakov.fedorapeople.org/plexus-digest.spec SRPM URL: http://akurtakov.fedorapeople.org/plexus-digest-1.0-8.fc11.src.rpm (In reply to comment #2) > X please make lines 126 and 144 <= 80 characters Fixed > X please remove "ghost symlink" comment since it's no longer true Fixed. > X the license appears to be exclusively ASL 2.0; remove " and Plexus" Fixed. > > OK sources match what I download > OK rpmlint output acceptable: > plexus-digest.noarch: W: no-documentation > plexus-digest.noarch: W: non-conffile-in-etc > /etc/maven/fragments/plexus-digest > Ok naming, versioning > OK files > OK requires > OK builds > OK macros > OK rm -rf at beginning of %install and %clean present New sources: Spec URL: http://akurtakov.fedorapeople.org/plexus-digest.spec SRPM URL: http://akurtakov.fedorapeople.org/plexus-digest-1.0-9.fc11.src.rpm Thanks, approved. New Package CVS Request ======================= Package Name: plexus-digest Short Description: Plexus Digest / Hashcode Components Owners: akurtakov overholt Branches: InitialCC: CVS Done |