Spec URL: http://akurtakov.fedorapeople.org/plexus-digest.spec SRPM URL: http://akurtakov.fedorapeople.org/plexus-digest-1.0-8.fc11.src.rpm Description: The Plexus project seeks to create end-to-end developer tools for writing applications. At the core is the container, which can be embedded or for a full scale application server. There are many reusable components for hibernate, form processing, jndi, i18n, velocity, etc. Plexus also includes an application server which is like a J2EE application server, without all the baggage.
This is a full review request. The pre-review request was bug #500249.
X please make lines 126 and 144 <= 80 characters X please remove "ghost symlink" comment since it's no longer true X the license appears to be exclusively ASL 2.0; remove " and Plexus" OK sources match what I download OK rpmlint output acceptable: plexus-digest.noarch: W: no-documentation plexus-digest.noarch: W: non-conffile-in-etc /etc/maven/fragments/plexus-digest Ok naming, versioning OK files OK requires OK builds OK macros OK rm -rf at beginning of %install and %clean present
(In reply to comment #2) > X please make lines 126 and 144 <= 80 characters Fixed > X please remove "ghost symlink" comment since it's no longer true Fixed. > X the license appears to be exclusively ASL 2.0; remove " and Plexus" Fixed. > > OK sources match what I download > OK rpmlint output acceptable: > plexus-digest.noarch: W: no-documentation > plexus-digest.noarch: W: non-conffile-in-etc > /etc/maven/fragments/plexus-digest > Ok naming, versioning > OK files > OK requires > OK builds > OK macros > OK rm -rf at beginning of %install and %clean present New sources: Spec URL: http://akurtakov.fedorapeople.org/plexus-digest.spec SRPM URL: http://akurtakov.fedorapeople.org/plexus-digest-1.0-8.fc11.src.rpm
(In reply to comment #2) > X please make lines 126 and 144 <= 80 characters Fixed > X please remove "ghost symlink" comment since it's no longer true Fixed. > X the license appears to be exclusively ASL 2.0; remove " and Plexus" Fixed. > > OK sources match what I download > OK rpmlint output acceptable: > plexus-digest.noarch: W: no-documentation > plexus-digest.noarch: W: non-conffile-in-etc > /etc/maven/fragments/plexus-digest > Ok naming, versioning > OK files > OK requires > OK builds > OK macros > OK rm -rf at beginning of %install and %clean present New sources: Spec URL: http://akurtakov.fedorapeople.org/plexus-digest.spec SRPM URL: http://akurtakov.fedorapeople.org/plexus-digest-1.0-9.fc11.src.rpm
Thanks, approved.
New Package CVS Request ======================= Package Name: plexus-digest Short Description: Plexus Digest / Hashcode Components Owners: akurtakov overholt Branches: InitialCC:
CVS Done
Built: http://koji.fedoraproject.org/koji/taskinfo?taskID=1623893