Bug 523228

Summary: libvirt-0.7.0-4 failed to build during RHEL-6 mass rebuild
Product: Red Hat Enterprise Linux 6 Reporter: Karsten Hopp <karsten>
Component: libvirtAssignee: Daniel Veillard <veillard>
Status: CLOSED CURRENTRELEASE QA Contact: Virtualization Bugs <virt-bugs>
Severity: high Docs Contact:
Priority: high    
Version: 6.0CC: berrange, markmc, xen-maint, yimwang
Target Milestone: beta   
Target Release: ---   
Hardware: s390x   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-09-30 09:53:40 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 522407, 523231, 523241    
Attachments:
Description Flags
New libvirt.spec to only build on libvirtd / QEMU on x86_64 RHEL-6
none
Updated RHEL-6 spec to fix RHEL-5/Fedora regressions none

Description Karsten Hopp 2009-09-14 14:24:21 UTC
Description of problem:
libvirt failed to build on s390x as there's no numactl-devel package and no package providing /usr/bin/qemu-img on that architecture. 


Steps to Reproduce:
1. run a brew scratch build with the target RHEL-6-rebuild, don't try without --scratch as that won't work

Actual results:
https://brewweb.devel.redhat.com/taskinfo?taskID=1949417


Additional info:
It needs to be discussed with IBM if we need qemu, libvirt, ... on s390x at all. Maybe an ExcludeArch will be sufficient.
We need the exact n-v-r of the fixed package so that we can import it into our RHEL-6 tree.

Comment 1 RHEL Program Management 2009-09-14 14:27:35 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux major release.  Product Management has requested further
review of this request by Red Hat Engineering, for potential inclusion in a Red
Hat Enterprise Linux Major release.  This request is not yet committed for
inclusion.

Comment 2 Mark McLoughlin 2009-09-14 14:38:38 UTC
IMHO, we'll want libvirt-client, at most, on s3890 - not libvirt itself or qemu

Comment 3 Daniel Berrangé 2009-09-14 14:45:44 UTC
My recommendation is that 

 - x86_64  - build libvirtd, build test, remote & QEMU drivers. Build storage, network, interface, node device drivers

 - i386, ppc, s390, ia64, etc -  build only the remote driver.

this will avoid the need to ExludeArch on countless downstream RPMs depending on libvirt - we explicitly created the new libvirt-client sub-RPM to allow for client-only deps which suits this scenario quite well. The only technical issue is to figure out the RPM conditional rules to make sure that *only* the libvirt-client RPM is output, with no 'libvirt' base RPM.

Comment 4 Daniel Berrangé 2009-09-14 17:09:31 UTC
Created attachment 360972 [details]
New libvirt.spec to only build on libvirtd / QEMU on x86_64  RHEL-6

The following is an updated specfile against libvirt upstream GIT repo.

It aims to do the following:

 RHEL-6
    - x86_64  build libvirtd, QEMU, LXC, Test & Remote driver and other secondary drivers (network, interface, hal node device, selinux)
    - All other archs:  build libvirt Remote & Test drivers only.  No libvirtd, or base RPM

This scratch build has verified it

   https://brewweb.devel.redhat.com/taskinfo?taskID=1984675

With this, there should be no need to conditionalize any other libvirt related downstream RPM

Comment 5 Daniel Berrangé 2009-09-14 17:27:40 UTC
Created attachment 360976 [details]
Updated RHEL-6 spec to fix RHEL-5/Fedora regressions 

The previous spec i uploaded didn't work for RHEL-5/Fedora. This one fixes the conditionals i broke, so it works on all RHEL and all Fedora now

Comment 6 Daniel Berrangé 2009-09-17 12:16:04 UTC
After more consideration this was all wrong.

We *DO* want a full libvirt build on all architectures, since we intend to include the LXC container virt driver which is available on all Linux archs. Therefore the need to build libvirtd everywhere, LXC everywhere, and QEMU only on x86_64.

Comment 7 Daniel Berrangé 2009-09-22 15:55:33 UTC
The latest RHEL6 build now includes s390

http://porkchop.devel.redhat.com/brewroot/packages/libvirt/0.7.1/2.el6.1/

Comment 8 Daniel Veillard 2009-09-30 09:53:40 UTC
Yeah I think this is fixed, let's close this,

Daniel

Comment 9 wangyimiao 2010-09-08 06:10:46 UTC
Verified passed
The latest RHEL6 build now includes s390

http://porkchop.devel.redhat.com/brewroot////packages/libvirt/0.8.1/27.el6/s390x/