Bug 527317
| Summary: | Review Request: django-flash - A Django extension to provide support for Rails-like flash | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sebastian Dziallas <sebastian> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-10-21 18:41:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 527319 | ||
|
Description
Sebastian Dziallas
2009-10-05 23:02:26 UTC
Just a new build, removing an unneeded BR. Spec URL: http://sdz.fedorapeople.org/rpmbuild/django-flash.spec SRPM URL: http://sdz.fedorapeople.org/rpmbuild/django-flash-1.6.2-2.fc11.src.rpm Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1732522 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 848eccac89400631209c0bea3ba714012e8e118f django-flash-1.6.2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application APPROVED. New Package CVS Request ======================= Package Name: django-flash Short Description: A Django extension to provide support for Rails-like flash Owners: sdz Branches: F-11 F-12 EL-5 Ah! Missed the fedora-cvs flag, adding that now. Request as above. cvs done. If this package is built for all required branches, can you close this review? All branches built. Closing. |