Bug 527317 - Review Request: django-flash - A Django extension to provide support for Rails-like flash
Summary: Review Request: django-flash - A Django extension to provide support for Rail...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 527319
TreeView+ depends on / blocked
 
Reported: 2009-10-05 23:02 UTC by Sebastian Dziallas
Modified: 2009-10-21 18:41 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-10-21 18:41:53 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Sebastian Dziallas 2009-10-05 23:02:26 UTC
Spec URL: http://sdz.fedorapeople.org/rpmbuild/django-flash.spec
SRPM URL: http://sdz.fedorapeople.org/rpmbuild/django-flash-1.6.2-1.fc11.src.rpm
Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1729589

[sebastian@localhost SRPMS]$ rpmlint -vi django-flash-1.6.2-1.fc11.src.rpm 
django-flash.src: I: checking
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[sebastian@localhost noarch]$ rpmlint -vi django-flash-1.6.2-1.fc11.noarch.rpm 
django-flash.noarch: I: checking
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

This is the second requirement in an effort to get TypePad Motion packaged for
Fedora.

Comment 1 Sebastian Dziallas 2009-10-06 11:48:59 UTC
Just a new build, removing an unneeded BR.

Spec URL: http://sdz.fedorapeople.org/rpmbuild/django-flash.spec
SRPM URL:
http://sdz.fedorapeople.org/rpmbuild/django-flash-1.6.2-2.fc11.src.rpm

Comment 2 Parag AN(पराग) 2009-10-07 09:25:38 UTC
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1732522
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
848eccac89400631209c0bea3ba714012e8e118f  django-flash-1.6.2.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

APPROVED.

Comment 3 Sebastian Dziallas 2009-10-07 18:15:37 UTC
New Package CVS Request
=======================
Package Name: django-flash
Short Description: A Django extension to provide support for Rails-like flash
Owners: sdz
Branches: F-11 F-12 EL-5

Comment 4 Sebastian Dziallas 2009-10-07 18:16:25 UTC
Ah! Missed the fedora-cvs flag, adding that now. Request as above.

Comment 5 Kevin Fenzi 2009-10-08 05:54:24 UTC
cvs done.

Comment 6 Parag AN(पराग) 2009-10-21 06:28:37 UTC
If this package is built for all required branches, can you close this review?

Comment 7 Sebastian Dziallas 2009-10-21 18:41:53 UTC
All branches built. Closing.


Note You need to log in before you can comment on or make changes to this bug.