Bug 532523
Summary: | Review request: jarjar - Jar Jar Links | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mary Ellen Foster <mefoster> |
Component: | Package Review | Assignee: | Steve Traylen <steve.traylen> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | akurtako, fedora-package-review, notting, rafaels, steve.traylen, viveklak |
Target Milestone: | --- | Flags: | steve.traylen:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | jarjar-0.9-5.fc11 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-03-16 00:34:42 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163776 |
Description
Mary Ellen Foster
2009-11-02 18:00:50 UTC
*** Bug 252082 has been marked as a duplicate of this bug. *** *** Bug 227066 has been marked as a duplicate of this bug. *** Looking now, can you do the whole gcj thing: https://fedoraproject.org/wiki/Packaging/Java#GCJ The directories in your package: /etc/maven/fragments /etc/maven /usr/share/maven2/poms /usr/share/maven2 are not specified in your package and your requires do not require packages that contain them. There should be symlink from /usr/share/javadoc/jarjar to /usr/share/javadoc/jarjar-0.9 Everything else looks good I would say at the moment, if you can fix those two and gcj items I'll do the review. Steve Thanks for the comments (and sorry for the delay)! Updated files are now here: Spec URL: http://www.macs.hw.ac.uk/~mef3/review/jarjar.spec SRPM URL: http://www.macs.hw.ac.uk/~mef3/review/jarjar-0.9-4.fc12.src.rpm Sorry for the delay. $ rpmlint SPECS/jarjar.spec SRPMS/jarjar-0.9-4.fc13.src.rpm \ RPMS/x86_64/jarjar-* SPECS/jarjar.spec:174: W: libdir-macro-in-noarch-package (main package) %attr(-,root,root) %{_libdir}/gcj/%{name} jarjar.src:174: W: libdir-macro-in-noarch-package (main package) %attr(-,root,root) %{_libdir}/gcj/%{name} jarjar-maven2-plugin.x86_64: W: no-documentation which is all expected so fine. The javadoc can and probably should be noarch though. %package javadoc Summary: Javadocs for %{name} Group: Documentation %if %{?fedora}%{!?fedora:0} >= 10 || %{?rhel}%{!?rhel:0} >= 6 BuildArch: noarch %endif Hi Mary, The review looks good, just change the docs to noarch and I'll approve. Steve http://koji.fedoraproject.org/koji/taskinfo?taskID=1825761 yes: rpmlint above. yes: package name. yes: spec file name yes: package guidelines. yes: GPLv2+ in .SPEC yes: GPLv2+ in reality. yes: COPYING file included. yes: english spec. yes: legible spec. yes: source matches upstream. $ md5sum jarjar-src-0.9.zip ~/rpmbuild/SOURCES/jarjar-src-0.9.zip 61825e60d0466e328c7d24a6cef2c643 jarjar-src-0.9.zip 61825e60d0466e328c7d24a6cef2c643 /home/steve/rpmbuild/SOURCES/jarjar-src-0.9.zip yes: builds (fc13) yes: build requires sane. yes: buils on archs - see koji yes: no locaes. yes: no ldconfig needed. yes: no system libs. yes: not reloc' yes: no duplicates. yes: pulls in jpackage-utils to own directories yes: everything %defatt yes: cleans everything. yes: macro use good. yes: contains code. yes: java doc in seperate package. yes: %doc not needed runtime. yes: no devel package. yes: no static libs. yes: no pkgconfig files. yes: no devel packages. yes: no .la files. yes: no gui. yes: %install cleans itself. yes: utf8. Mary, Can you do the needed changes? It is needed for the Fedora AutoQA project. See https://fedoraproject.org/wiki/User:Jlaska/gwt . Sorry about that -- this got over looked. :( Here is the new version with the javadoc as noarch. Spec URL: http://www.macs.hw.ac.uk/~mef3/review/jarjar.spec SRPM URL: http://www.macs.hw.ac.uk/~mef3/review/jarjar-0.9-5.fc12.src.rpm APPROVED. New Package CVS Request ======================= Package Name: jarjar Short Description: Jar Jar Links Owners: mef Branches: F-11 F-12 CVS done (by process-cvs-requests.py). jarjar-0.9-5.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/jarjar-0.9-5.fc11 jarjar-0.9-5.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/jarjar-0.9-5.fc12 jarjar-0.9-5.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update jarjar'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1945 jarjar-0.9-5.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update jarjar'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-1722 jarjar-0.9-5.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. jarjar-0.9-5.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |