Bug 535772 (RHQ-2433)
| Summary: | Internet Explorer (IE) problem with Advanced Settings | ||
|---|---|---|---|
| Product: | [Other] RHQ Project | Reporter: | dsteigne |
| Component: | Core UI | Assignee: | Filip Drabek <fdrabek> |
| Status: | CLOSED WORKSFORME | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 3.0.0 | CC: | cwelton, don.craddock, hrupp, loleary, mlevens, rtimaniy, wdh |
| Target Milestone: | --- | Keywords: | Reopened, SubBug |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | http://jira.rhq-project.org/browse/RHQ-2433 | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: |
Internet Explorer version 7.0 Also confirmed on IE8
|
|
| Last Closed: | 2013-08-31 11:04:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 616081 | ||
|
Description
dsteigne
2009-09-16 20:44:00 UTC
Also fails in rev5152 on IE8 WORKAROUND: Click on the metric in the chart. At the bottom of the screen is the Advanced Settings (Display Range Settings). It is working from this location. This bug was previously known as http://jira.rhq-project.org/browse/RHQ-2433 Temporarily adding the keyword "SubBug" so we can be sure we have accounted for all the bugs. keyword: new = Tracking + FutureFeature + SubBug making sure we're not missing any bugs in rhq_triage closing per gwt effort This issue seems to keep getting reported/hit by customers. With such a simple fix, it might be worth getting the fix committed in lieu of the GWT effort in RHQ 4 and the workaround proposed in Comment 2. The 'onclick' event for the "Advanced Settings..." link is calling the JavaScript window.open() method with an invalid 'strWindowName' parameter. <a href="#" onclick="javascript:window.open('/rhq/common/metric/advanced.xhtml','Metric Display Range Settings','width=450,height=375');">Advanced Settings...</a> Although spaces in the window name value are tolerated in many web browsers, some browsers will fail to execute the window.open() method due to the value of "Metric Display Range Settings". The window name value must be a valid identifier and therefore can not contain spaces in its name: See: https://developer.mozilla.org/en/DOM/window.open I performed a quick search of the code and it appears that this is the only place that such a thing has occurred. diff --git a/modules/enterprise/gui/portal-war/src/main/java/org/rhq/enterprise/gui/common/metric/MetricRenderer.java b/modules/enterprise/gui/portal-war/src/main/java/org/rhq/enterprise/gui/common/metric/MetricRenderer.java index 0018101..d4a44e1 100644 --- a/modules/enterprise/gui/portal-war/src/main/java/org/rhq/enterprise/gui/common/metric/MetricRenderer.java +++ b/modules/enterprise/gui/portal-war/src/main/java/org/rhq/enterprise/gui/common/metric/MetricRenderer.java @@ -129,7 +129,7 @@ public class MetricRenderer extends Renderer { writer.startElement("a", null); writer.writeAttribute("href", "#", null); writer.writeAttribute("onclick", - "javascript:window.open('/rhq/common/metric/advanced.xhtml','Metric Display Range Settings','" + "javascript:window.open('/rhq/common/metric/advanced.xhtml','MetricDisplayRangeSettings','" + getWindowOptions() + "');", null); if (rangePreferences.readOnly) { writer.write("Edit Settings..."); *** Bug 574769 has been marked as a duplicate of this bug. *** commit 6b251b7c1d4c7f8f32ea49df17732d72ab06adde release-3 branch Tested in JON 2.4.1 Browser IE-7/8 "Advanced Settings" links of monitoring tab of a resource shows pop-up to change the time interval and it works fine. Has been verified loong time ago |