Bug 537798
| Summary: | [abrt] crash detected in gnome-panel-2.28.0-13.fc12 (/usr/libexec/clock-applet) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Douglas Furlong <bugzilla_rhn> | ||||
| Component: | gnome-panel | Assignee: | Ray Strode [halfline] <rstrode> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 12 | CC: | danlsgiga, gjalves, ink08, johann, johe.stephan, kaiarne5, linux, mail, manolisT29s2001, milan.slanar, musmeh55, r_brakchi, rod.c.johnson, rstrode, thingie, unix63, yyovkov | ||||
| Target Milestone: | --- | Keywords: | Triaged | ||||
| Target Release: | --- | ||||||
| Hardware: | i686 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | abrt_hash:2664fbc67530961b33e0e7d01a3a383c48390bb3 | ||||||
| Fixed In Version: | gnome-panel-2.28.0-16.fc12 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2010-03-11 07:24:22 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Douglas Furlong
2009-11-16 11:51:55 UTC
Created attachment 369674 [details]
File: backtrace
*** Bug 537721 has been marked as a duplicate of this bug. *** *** Bug 523871 has been marked as a duplicate of this bug. *** *** Bug 533428 has been marked as a duplicate of this bug. *** *** Bug 537592 has been marked as a duplicate of this bug. *** *** Bug 537532 has been marked as a duplicate of this bug. *** *** Bug 530903 has been marked as a duplicate of this bug. *** *** Bug 539343 has been marked as a duplicate of this bug. *** *** Bug 537237 has been marked as a duplicate of this bug. *** *** Bug 539404 has been marked as a duplicate of this bug. *** *** Bug 539897 has been marked as a duplicate of this bug. *** *** Bug 538647 has been marked as a duplicate of this bug. *** *** Bug 541649 has been marked as a duplicate of this bug. *** *** Bug 541789 has been marked as a duplicate of this bug. *** *** Bug 543090 has been marked as a duplicate of this bug. *** *** Bug 545021 has been marked as a duplicate of this bug. *** *** Bug 544521 has been marked as a duplicate of this bug. *** So the code has:
/* Used to count the number of clock instances. It's there to know when we•
* should free resources that are shared. */•
static int clock_numbers = 0;•
[...]
⟾ clock_numbers++;•
⟾ e_passwords_init ();•
[...]
#ifdef HAVE_LIBECAL•
⟾ if (clock_numbers > 0) {•
⟾ ⟾ e_passwords_shutdown ();•
⟾ ⟾ clock_numbers--;•
⟾ }•
#endif•
The docs don't mention e_passwords_init being ref counted internally, so i don't know why we're calling init() and shutdown() more than once.
Looking at the code e-d-s code, there's a bug in shutdown:
def WITH_GNOME_KEYRING•
⟾ g_free (default_keyring);•
#endif•
default_keyring isn't getting nullified after the free. This makes the shutdown function not idempotent.
Two possible fixes:
1) nullify default_keyring on free
2) only call shutdown when clock_numbers decrements to 0.
Given that clock_numbers is only used for shutdown and init, i'll assume it's original intent was for 2 to happen and someone just had a think-o.
gnome-panel-2.28.0-16.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/gnome-panel-2.28.0-16.fc12 I have updated to gnome-panel-2.28.0-16.fc12 from the page mentioned above. Sadly I am still not able to press ALT-F2 (i.e. open the run dialog).
I installed all debug packages and attached gdb to gnome-panel:
(gdb) bt
#0 0x004abbea in gmenu_tree_directory_get_contents (directory=0x0) at gmenu-tree.c:1008
#1 0x0807de85 in get_all_applications_from_dir (directory=<value optimized out>, list=<value optimized out>)
at panel-run-dialog.c:833
#2 0x0807dfa7 in get_all_applications () at panel-run-dialog.c:873
#3 0x0807e03d in panel_run_dialog_add_items_idle (dialog=<value optimized out>) at panel-run-dialog.c:905
#4 0x00189312 in g_idle_dispatch (source=<value optimized out>, callback=<value optimized out>, user_data=<value optimized out>)
at gmain.c:4065
#5 0x0018b128 in g_main_dispatch (context=<value optimized out>) at gmain.c:1960
#6 IA__g_main_context_dispatch (context=<value optimized out>) at gmain.c:2513
#7 0x0018ea58 in g_main_context_iterate (context=<value optimized out>, block=<value optimized out>,
dispatch=<value optimized out>, self=<value optimized out>) at gmain.c:2591
#8 0x0018eecf in IA__g_main_loop_run (loop=<value optimized out>) at gmain.c:2799
#9 0x07c57b99 in IA__gtk_main () at gtkmain.c:1218
#10 0x08060fea in main (argc=<value optimized out>, argv=<value optimized out>) at main.c:110
Hi Felix, This bug was meant to address a crash in the clock applet, not the run dialog. If you are one of the many duplicate bug reports on this bug, you may have been misduped. Can you reopen your bug report? I have been the first dupe of this report in comment #2 i reported my issue now at bug #546043. gnome-panel-2.28.0-16.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update gnome-panel'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-12992 gnome-panel-2.28.0-16.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update gnome-panel'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-12992 gnome-panel-2.28.0-16.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. |