Bug 541004 (pkcs11-dump)
| Summary: | Review Request: pkcs11-dump - Small utility for querying PKCS#11 modules | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kalev Lember <kalevlember> |
| Component: | Package Review | Assignee: | Antti Andreimann <antti.andreimann> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | antti.andreimann, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | antti.andreimann:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.3.3-1.fc12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-11-27 21:36:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Kalev Lember
2009-11-24 17:33:15 UTC
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1827769 Reviewed according to http://fedoraproject.org/wiki/Packaging/ReviewGuidelines Legend: OK - no problems N/A - requirement not applicable for this package ERR - requirement not met ATN - requirement met, but needs attention DNR - item was not checked by the reviewer (usually because it's optional) Required items: [ OK ] no rpmlint errors or warnings [ OK ] correct package naming [ OK ] correct spec naming [ OK ] acceptable license [ OK ] correct license field [ OK ] license file in %doc [ OK ] correct spec language [ OK ] acceptable spec legibility [ OK ] sources match upstream 96b8eb05037d3033638f54ae46b1bbb3 pkcs11-dump-0.3.3.tar.bz2 [ OK ] builds on primary architectures (i686, x86_64) [ N/A ] correct ExcludeArchs [ OK ] correct BuildRequires [ N/A ] properly handled locales [ N/A ] ldconfig in %post and %postun [ OK ] no system libraries [ OK ] no relocation [ OK ] correct directory ownership [ OK ] no duplicates in %files section [ OK ] permissions set correctly [ OK ] %clean section removes build root [ OK ] consistent macro usage [ OK ] contains only code (no standalone content) [ OK ] large documentation in -doc sub-package [ OK ] files in %doc not required to function [ N/A ] header files in -devel sub-package [ N/A ] static libraries in -static sub-package [ N/A ] proper use of Requires: pkgconfig [ N/A ] .so files in -devel sub-package [ N/A ] fully versioned dependency in -devel package [ N/A ] no libtool archives (.la files) in package [ N/A ] %{name}.desktop file(s) installed for GUI applications [ OK ] does not claim ownership to other package directories [ OK ] %install section removes buildroot [ OK ] filenames in UTF-8 Optional items: [ N/A ] ask upstream to include license text in separate file [ N/A ] description and summary available in different languages [ OK ] package builds in mock [ DNR ] package builds on all supported architectures [ DNR ] package functions as described [ N/A ] rpm scriptlets are sane [ N/A ] all sub-packages have fully versioned dependency [ N/A ] .pc files in -devel sub-package [ OK ] no file dependencies outside of "bin" directories Additional items by the reviewer: [ OK ] verbose build logs, compiler flags are visible [ OK ] RPM_OPT_FLAGS are honoured [ OK ] original timestamps are preserved Thanks for the quick review, Antti! New Package CVS Request ======================= Package Name: pkcs11-dump Short Description: Small utility for querying PKCS#11 modules Owners: kalev Branches: F-11 F-12 InitialCC: cvs done. pkcs11-dump-0.3.3-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/pkcs11-dump-0.3.3-1.fc12 pkcs11-dump-0.3.3-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/pkcs11-dump-0.3.3-1.fc11 pkcs11-dump-0.3.3-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. pkcs11-dump-0.3.3-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. |