Bug 541004 - (pkcs11-dump) Review Request: pkcs11-dump - Small utility for querying PKCS#11 modules
Review Request: pkcs11-dump - Small utility for querying PKCS#11 modules
Status: CLOSED ERRATA
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Antti Andreimann
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2009-11-24 12:33 EST by Kalev Lember
Modified: 2009-11-27 16:39 EST (History)
3 users (show)

See Also:
Fixed In Version: 0.3.3-1.fc12
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-11-27 16:36:31 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
antti.andreimann: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Kalev Lember 2009-11-24 12:33:15 EST
Spec URL: http://kalev.fedorapeople.org/pkcs11-dump.spec
SRPM URL: http://kalev.fedorapeople.org/pkcs11-dump-0.3.3-1.fc13.src.rpm
Description:
pkcs11-dump is a small utility for querying PKCS#11 provider
modules for objects available on a specific crypto device
and dumping them to stdout in a human-readable format.
Comment 1 Kalev Lember 2009-11-24 13:17:59 EST
Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1827769
Comment 2 Antti Andreimann 2009-11-24 14:45:21 EST
Reviewed according to
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

Legend:
OK  - no problems
N/A - requirement not applicable for this package
ERR - requirement not met
ATN - requirement met, but needs attention
DNR - item was not checked by the reviewer (usually because it's optional)

Required items:
[ OK  ] no rpmlint errors or warnings
[ OK  ] correct package naming
[ OK  ] correct spec naming
[ OK  ] acceptable license
[ OK  ] correct license field
[ OK  ] license file in %doc
[ OK  ] correct spec language
[ OK  ] acceptable spec legibility
[ OK  ] sources match upstream
        96b8eb05037d3033638f54ae46b1bbb3  pkcs11-dump-0.3.3.tar.bz2
[ OK  ] builds on primary architectures (i686, x86_64)
[ N/A ] correct ExcludeArchs
[ OK  ] correct BuildRequires
[ N/A ] properly handled locales
[ N/A ] ldconfig in %post and %postun
[ OK  ] no system libraries
[ OK  ] no relocation
[ OK  ] correct directory ownership
[ OK  ] no duplicates in %files section
[ OK  ] permissions set correctly
[ OK  ] %clean section removes build root
[ OK  ] consistent macro usage
[ OK  ] contains only code (no standalone content)
[ OK  ] large documentation in -doc sub-package
[ OK  ] files in %doc not required to function
[ N/A ] header files in -devel sub-package
[ N/A ] static libraries in -static sub-package
[ N/A ] proper use of Requires: pkgconfig
[ N/A ] .so files in -devel sub-package
[ N/A ] fully versioned dependency in -devel package
[ N/A ] no libtool archives (.la files) in package
[ N/A ] %{name}.desktop file(s) installed for GUI applications
[ OK  ] does not claim ownership to other package directories
[ OK  ] %install section removes buildroot
[ OK  ] filenames in UTF-8

Optional items:
[ N/A ] ask upstream to include license text in separate file
[ N/A ] description and summary available in different languages
[ OK  ] package builds in mock
[ DNR ] package builds on all supported architectures
[ DNR ] package functions as described
[ N/A ] rpm scriptlets are sane
[ N/A ] all sub-packages have fully versioned dependency
[ N/A ] .pc files in -devel sub-package
[ OK  ] no file dependencies outside of "bin" directories

Additional items by the reviewer:
[ OK  ] verbose build logs, compiler flags are visible
[ OK  ] RPM_OPT_FLAGS are honoured
[ OK  ] original timestamps are preserved
Comment 3 Kalev Lember 2009-11-24 14:53:09 EST
Thanks for the quick review, Antti!

New Package CVS Request
=======================
Package Name: pkcs11-dump
Short Description: Small utility for querying PKCS#11 modules
Owners: kalev
Branches: F-11 F-12
InitialCC:
Comment 4 Kevin Fenzi 2009-11-27 00:24:59 EST
cvs done.
Comment 5 Fedora Update System 2009-11-27 02:39:46 EST
pkcs11-dump-0.3.3-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/pkcs11-dump-0.3.3-1.fc12
Comment 6 Fedora Update System 2009-11-27 02:39:51 EST
pkcs11-dump-0.3.3-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/pkcs11-dump-0.3.3-1.fc11
Comment 7 Fedora Update System 2009-11-27 16:36:26 EST
pkcs11-dump-0.3.3-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 8 Fedora Update System 2009-11-27 16:38:54 EST
pkcs11-dump-0.3.3-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.