Bug 548180
| Summary: | Review Request: hostapd - IEEE 802.11 AP, IEEE 802.1X/WPA/WPA2/EAP/RADIUS Authenticator | |||
|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | John W. Linville <linville> | |
| Component: | Package Review | Assignee: | Nicolas Chauvet (kwizart) <kwizart> | |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | medium | |||
| Version: | rawhide | CC: | adel.gadllah, fedora-package-review, goeran, herrold, JamesAAllsopp, kwizart, kyle, lemenkov, negativo17, notting, tom | |
| Target Milestone: | --- | Flags: | kwizart:
fedora-review+
gwync: fedora-cvs+ |
|
| Target Release: | --- | |||
| Hardware: | All | |||
| OS: | Linux | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | Bug Fix | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 549498 (view as bug list) | Environment: | ||
| Last Closed: | 2009-12-21 20:41:32 UTC | Type: | --- | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 549498 | |||
|
Description
John W. Linville
2009-12-16 20:39:06 UTC
*** Bug 545169 has been marked as a duplicate of this bug. *** *** Bug 494171 has been marked as a duplicate of this bug. *** - starting review - kwizart, I snuck-in a new copy using gnutls instead of openssl -- please take note! :-) * Wed Dec 16 2009 John W. Linville <linville> - 0.6.9-3 - Use gnutls instead of openssl (avoid license disputes) - Turn-off internal EAP server (broken w/ gnutls) - Remove %doc files not applicable to chosen configuration - Un-mangle README filename for logwatch sub-package * You need to use our $RPM_OPT_FLAGS (at this time it only uses -O2 -Wall -g) * It's better to use "install -p" to prevent timestamp changes. (fixed in -3) * There are lot of commented options. Some are tagged as experimental, But I wonder if others cannot be enabled ? (this doesn't concern the Driver Interfaces). Specially as the CONFIG_EAP_FAST=y which requires the newer openssl * This package doesn't use a dist tag , Why ? TODO -> Duplication code verification, in progress. -> Runtime test on ath5k driver. Most of the "commented options" (I presume you mean in .config) relate to the internal EAP server. Jouni tells me that it is broken when using gnutls, so I disabled the related options when I changed the configuration to using gnutls. We could reenable some number of them if we use openssl instead, but I wanted to avoid the license disputes. The others relate to newer 802.11 features that may or may not be useful.
I simply forgot the RPM_OPT_FLAGS and dist tag -- this one is a bit more of a pain to package than most. :-) Also, I had to hack the Makefile a bit to make RPM_OPT_FLAGS practical...
* Wed Dec 16 2009 John W. Linville <linville> - 0.6.9-4
- Remove wired.conf from %doc (not in chosen configuration)
- Use $RPM_OPT_FLAGS
- Add %{?dist} tag
*sigh* WPA-PSK connections seem to be broken with gnutls and/or turning-off all the EAP stuff. So, what are the ramifications of using openssl? If we go this route, we can reevaluate some of the other stuff in .config... * Wed Dec 16 2009 John W. Linville <linville> - 0.6.9-5 - Use openssl instead of gnutls (broken) *** Bug 230449 has been marked as a duplicate of this bug. *** * Thu Dec 17 2009 John W. Linville <linville> - 0.6.9-6 - Enable RADIUS server - Enable "wired" and "none" drivers - Use BSD license option SRPM: http://linville.fedorapeople.org/hostapd-0.6.9-6.fc11.src.rpm I notice you haven't uncommented CONFIG_IEEE80211N in the configuration so it won't have 802.11n support. The build I'm using at the moment does have that enabled (although I don't have any clients to test it with) and it doesn't seem to have caused any problems. Tom, thanks for the report! I would be open to enabling that, just haven't tested it myself. If you don't mind, let's get the package approved and then we can play with further configuration options...fair enough? I can provide runtime testing on ath9k on 802.11n, if needed. I'd love to see this package accepted with the full set of features that I'd be using. :) I wasn't able to use hostapd with the nl80211 driver on Fedora 11, but everything went fine for Fedora 12 using an atheros hardware. (none work with intel and a iwl3945 driver) ++++++++++++++++++++++++++++++++++++++++ This package (hostapd) is APPROVED by me ++++++++++++++++++++++++++++++++++++++++ (In reply to comment #15) > I wasn't able to use hostapd with the nl80211 driver on Fedora 11, but > everything went fine for Fedora 12 using an atheros hardware. > (none work with intel and a iwl3945 driver) > > ++++++++++++++++++++++++++++++++++++++++ > > This package (hostapd) is APPROVED by me > > ++++++++++++++++++++++++++++++++++++++++ Thanks for finally packing and reviewing this one ;) As for the intel issue it is not supported at the driver side. New Package CVS Request ======================= Package Name: hostapd Short Description: IEEE 802.11 AP, IEEE 802.1X/WPA/WPA2/EAP/RADIUS Authenticator Owners: linville Branches: F-12 InitialCC: linville cvs done. FYI: I picked up hostapd-0.6.9-6.fc12.x86_64 from Koji and tried with the ath5k driver and a Nintendo Wii on the other end. Worked fine! :-) I don't know why I couldn't get it to work with my previous local build. But it's always good with folks that know what they are doing. Package Change Request ====================== Package Name: hostapd New Branches: el6 Owners: slaanesh linville Git done (by process-git-requests). |