Bug 550600
| Summary: | Review Request: themonospot-gui-gtk - Gtk gui to scan multimedia files using Themonospot | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Armando Basile <hmandevteam> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, mtasaka, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://www.integrazioneweb.com/themonospot/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-01-11 14:56:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 550594 | ||
| Bug Blocks: | 550519 | ||
|
Description
Armando Basile
2009-12-26 09:08:34 UTC
SPEC URL: http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-gui-gtk.spec SRPM URL: http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-gui-gtk-0.2.0-2.fc12.src.rpm changes: - added BuildRequires: themonospot-base-devel - removed min. release req. for mono-core and themonospot-base - added copying.gpl For -2: * Obsoletes - (I also added some comments on bug 550594) At first I thought this package (i.e. -gui-gtk) should obsolete the old themonospot, however maybe -base should obsolete it. Anyway please add "Obsoletes: themonospot <= <specific_version>" to the proper package. Currently I am not sure if "Provides: themonosport = <some_version>" should be added or not. * Timestamps - Same as bug 550599 - Also please consider to use ---------------------------------------------------------- make DESTDIR=%{buildroot} INSTALL="install -p" install ---------------------------------------------------------- to keep timestamps on installed files as much as possible (for this package this should keep timestamp on pixmap file) This method usually works for Makefiles generated by recent autotools * desktop-file-install https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage - "--vendor="fedora" should no longer be used - you may use "--delete-original" option for desktop-file-install instead of removing desktop file firstly installed under %buildroot, or you can use desktop-file-validate instead of desktop-file-install. ! dependency against -plugin-mkv ! Currently this package "crashes" without having -plugin-mkv installed with - type $ mono --debug /usr/lib/themonospot-gui-gtk/themonospot-gui-gtk.exe - click "Folder" - On the pop-up window titled "Select folder to scan", choose a directory and click "Open" Then: --------------------------------------------------------------- [tasaka1@foo ~]$ mono --debug /usr/lib/themonospot-gui-gtk/themonospot-gui-gtk.exe OS: NON Windows configuration file path: /home/tasaka1/.themonospot.xml Unhandled Exception: System.NullReferenceException: Object reference not set to an instance of an object at ThemonospotGuiGtk.MainWindowClass.ScanFolder (System.String folderPath, Boolean recursive) [0x00000] in <filename unknown>:0 at ThemonospotGuiGtk.MainWindowClass.StartScanFolder (System.String folderPath, Boolean recursive) [0x00000] in <filename unknown>:0 at ThemonospotGuiGtk.MainWindowClass+<OpenFolder>c__AnonStorey0.<>m__0 () [0x00000] in <filename unknown>:0 --------------------------------------------------------------- SPEC URL: http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-gui-gtk.spec SRPM URL: http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-gui-gtk-0.2.1-1.fc12.src.rpm changes: - added copying.gpl - folder used is %{libdir}/themonospot Still themonospot-gui crashes (as I wrote in the comment 2) if neither -plugin-{mkv,avi} is installed. Is this difficult to fix? SPEC URL: http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-gui-gtk.spec SRPM URL: http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-gui-gtk-0.2.2-1.fc12.src.rpm changed: - bug fix: scan process without plugin installed - only mono-devel and desktop-file-utils as BuildRequire Well, while "Requires: gtk-sharp2 themonospot-base mono-core" can be removed with "BuildRequires: mono-devel", "BuildRequires: gtk-sharp2-devel themonospot-base-devel" are still needed (and same on other themonospot-foo packages) SPEC URL: http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-gui-gtk.spec SRPM URL: http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-gui-gtk-0.2.2-2.fc12.src.rpm change: - gtk-sharp2-devel - themonospot-base-devel For 0.2.2-2 * desktop-file-install usage https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage - As I wrote in my comment 2, "--vendor=fedora" is now deprecated and should be removed (and the name of the desktop included in binary rpm should be "themonospot-gtk.desktop") You can use ------------------------------------------------------- %install rm -fr %{buildroot} make DESTDIR=%{buildroot} install desktop-file-install \ --dir %{buildroot}%{_datadir}/applications \ --delete-original \ %{buildroot}%{_datadir}/applications/themonospot-gtk.desktop ------------------------------------------------------- or even: ------------------------------------------------------- %install rm -fr %{buildroot} make DESTDIR=%{buildroot} install desktop-file-validate %{buildroot}%{_datadir}/applications/themonospot-gtk.desktop ------------------------------------------------------- SPEC URL: http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-gui-gtk.spec SRPM URL: http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-gui-gtk-0.2.2-3.fc12.src.rpm changed: - modified desktop-file-install macro parameters Okay. ------------------------------------------------------------- This package (themonospot-gtk-gui) is APPROVED by mtasaka ------------------------------------------------------------- New Package CVS Request ======================= Package Name: themonospot-gui-gtk Short Description: Gtk gui for Themonospot suite Owners: hman Branches: F-11 F-12 InitialCC: mtasaka Cvsextras Commits: yes New Package CVS Request ======================= Package Name: themonospot-gui-gtk Short Description: Gtk gui for Themonospot suite Owners: hman-it Branches: F-11 F-12 InitialCC: mtasaka Cvsextras Commits: yes cvs done. Closing. |