SPEC URL: http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-console.spec SRPM URL: http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-console-0.1.0-1.fc12.src.rpm Description: themonospot-console is a mono console application to scan multimedia files using themonospot base component and his plugins.
Some notes: * License - There is no license information in the tarball. Would you clarify it (as you are the upstream)? * (Build)Requires - As I wrote in -base review, ">= 1.2.3" part on (Build)Requires: mono-core is not needed (for current Fedora) - Also ">= 0.8.1" part on (Build)Requires: themonospot-console is not needed either because -core packages to be intoduced into Fedora satisfies this version dependency on every Fedora branch. ref: the last sentence in https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires * %files - %files entry "%{_bindir}/%{name}/" is wrong because the last slash should mean that this %files entry is a directory, while the actually installed one is a file, not a directory. (i.e. this should be "%{_bindir}/%{name}") ! Note In reality, current rpm simply ignores the last slash. https://bugzilla.redhat.com/show_bug.cgi?id=505995
SPEC URL: http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-console.spec SRPM URL: http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-console-0.1.0-2.fc12.src.rpm changes: - removed ">= 1.2.3" from mono-core dependence - removed ">= 0.8.1" from themonospot-base dependence - added themonospot-base-devel to BuildRequires - removed final "/" in "%{_bindir}/%{name}/" line for license, should patch tarball (adding gplv2 file) and add patch to spec ?
I have not checked your latest srpm, however: (In reply to comment #2) > for license, should patch tarball (adding gplv2 file) and add patch to spec ? - If you want to modify the tarball itself (i.e. include license text in the tarball) please release the new version (i.e. 0.1.0.1, for example) - If you want not to release the new version for now, for now include the license text as SourceX in srpm and package it into binary rpm with %doc. Anyway in the next version please include the license text in the tarball.
SPEC URL: http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-console.spec SRPM URL: http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-console-0.1.0-3.fc12.src.rpm changes: - added Source1 copyng.gpl - added cp %{SOURCE1} copying.gpl - added %doc copying.gpl
For -3: * Timestamps - Use "cp -p" to keep timestamps on installed files ! %changelog - As I wrote in -base review request, please add new %changelog entry even during review process. This review will be accepted once bug 550594 is accepted.
SPEC URL: http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-console.spec SRPM URL: http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-console-0.1.1-1.fc12.src.rpm changes: - folder used is %{libdir}/themonospot - added copying.gpl
SPEC URL: http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-console.spec SRPM URL: http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-console-0.1.1-2.fc12.src.rpm changes: - only mono-devel as BuildRequire
SPEC URL: http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-console.spec SRPM URL: http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-console-0.1.1-3.fc12.src.rpm changed: - added themonospot-base-devel as BuildRequire
Okay. ---------------------------------------------------------------- This package (themonospot~console) is APPROVED by mtasaka ----------------------------------------------------------------
New Package CVS Request ======================= Package Name: themonospot-console Short Description: Console application for Themonospot suite Owners: hman Branches: F-11 F-12 InitialCC: mtasaka.u-tokyo.ac.jp Cvsextras Commits: yes
New Package CVS Request ======================= Package Name: themonospot-console Short Description: Console application for Themonospot suite Owners: hman-it Branches: F-11 F-12 InitialCC: mtasaka Cvsextras Commits: yes
cvs done.
Closing.