SPEC URL: http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-base.spec SRPM URL: http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-base-0.8.1-1.fc12.src.rpm Description: It install: - themonospot-base mono assembly in GAC (use from other gui applications) - themonospot-plugin-interface in GAC (use to write plugins) - themonospot-plugin-manager (use to load plugins at runtime) - xml language files
First of all, please upload the correct spec files for Fedora (not for Mandriva) which correspond to the srpms you uploaded.
i'm sorry, i uploaded correct spec files
Well, I am not familiar with mono, but anyway: * BuildRequires / Requires - ">= 1.2.3" part of (Build)Requires: mono-core is not needed. Fedora 11 already has version 2.4. * pkgconfig .pc file - should be moved to -devel subpackage: https://fedoraproject.org/wiki/Packaging/Mono#-devel_packages
SPEC URL: http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-base.spec SRPM URL: http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-base-0.8.1-2.fc12.src.rpm changes: - removed ">= 1.2.3" in spec file - added package devel creation in spec file
SPEC URL: http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-base.spec SRPM URL: http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-base-0.8.1-3.fc12.src.rpm changes: - moved "BuildRequires: pkgconfig" from -devel to main package
For -3: * Directory ownership issue - Forgot to notice this, however ------------------------------------------------------------- 53 %files 57 %{_libdir}/mono/ ------------------------------------------------------------- This package should now own the directories /usr/lib/mono, /usr/lib/mono/gac (on i686) themselves because these directories themselves are already owned by mono-core. ! %changelog - Please actually add new %changelog even during review process
By the way what component should have "Obsoletes: themonospot" (i.e remove old themonospot) ?
SPEC URL: http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-base.spec SRPM URL: http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-base-0.8.2-1.fc12.src.rpm changes: - no more GAC use - set plugins location %{_libdir}/themonospot/plugins - datadir used only for language files - added copying.gpl to all suite projects > By the way what component should > have "Obsoletes: themonospot" (i.e > remove old themonospot) ? yes, themonospot-base should have "Obsoletes: themonospot"
For 0.8.2-1: * BuildRequires/Requires - Well, I did not notice before, however: current rpm-build (F-11/12/13) has /usr/lib/rpm/mono-find-{provides,requires}, so dependency on mono .dll files should be automatically detected. However, for example rawhide rpmbuild-4.8.0-0.beta1.4 mono-find-requires reads: ----------------------------------------------------------- 21 if [ -x $build_bindir/monodis ]; then 22 monodis="$build_bindir/monodis" 23 export LD_LIBRARY_PATH=$build_libdir${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH} 24 elif [ -x /usr/bin/monodis ]; then 25 monodis="/usr/bin/monodis" 26 else 27 exit 0; 28 fi ----------------------------------------------------------- So to detect .dll based depedency automatically, /usr/bin/monodis is needed, which is in mono-devel. So: * Change "BR: mono-core" to "BR: mono-devel" * "BR: pkgconfig" is not needed because mono-devel always requires pkgconfig * "Requires: mono-core" is not needed because dependency on .dll files will automatically be detected after using "BR: mono-devel" ! Note: For other themonospot-foo packages, writing "Requires: themonospot-base" or other dll based dependencies explicitly is also no longer needed with using "BR: mono-devel" (still "BR: themonospot-devel" or so is needed for other themonospot-foo srpm) * Obsoletes (In reply to comment #8) > > By the way what component should > > have "Obsoletes: themonospot" (i.e > > remove old themonospot) ? > yes, themonospot-base should have > "Obsoletes: themonospot" - Then please add this.
SPEC URL: http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-base.spec SRPM URL: http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-base-0.8.2-2.fc12.src.rpm changes: - added mono-devel as BuildRequires (to detect mono dependency automatically) - removed mono-core from BuildRequires and Requires - removed pkgconfig from BuildRequires - added themonospot to Obsoletes
For 0.8.2-2 * Unversioned Obsoletes ------------------------------------------------------------- Obsoletes: themonospot ------------------------------------------------------------- - This unversioned Obsoletes statement may cause problem in the future (for example when "themonospot" comes back). It is highly recommended to specify the version for Obsoletes. On Fedora the following is sufficient (so change to below) ------------------------------------------------------------- Obsoletes: themonospot < 0.8.0 ------------------------------------------------------------- For this package I don't think adding virtual Provides for themonosport is strictly needed, however you may want to add the following: ------------------------------------------------------------- Provides: themonospot = %{version} ------------------------------------------------------------- * %description ------------------------------------------------------------- themonospot-base is core package for themonospot system. It install: - themonospot-base mono assembly in GAC (use from other gui applications) ------------------------------------------------------------- - Again I am not familiar with mono, however your %changelog says: ------------------------------------------------------------- * Wed Dec 30 2009 Armando Basile <hmandevteam> 0.8.2-1 - removed GAC use ------------------------------------------------------------- So this description may be outdated. Please fix this if necessary. Other things are okay. Please fix above when importing into Fedora CVS. ------------------------------------------------------------- This package (themonospot-base) is APPROVED by mtasaka -------------------------------------------------------------
One more thing: * Detecting dependency - To make it sure that all dependencies are correctly detected, change the permission of .dll files to 0755 explicitly as ------------------------------------------------------------- chmod 0755 %{buildroot}%{_libdir}/themonospot/*.dll ------------------------------------------------------------- at the end of %install section ( currently 2 dll files has 0644 permission and unfortunately rpmbuild does not check dependency for .dll files if they don't have executable permission )
SPEC URL: http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-base.spec SRPM URL: http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-base-0.8.2-4.fc12.src.rpm changes: - changed file permissions for dll assembly after buildroot install - added versioning to Obsoletes - fixed description
Okay, please write CVS request.
New Package CVS Request ======================= Package Name: themonospot-base Short Description: Core component of Themonospot suite Owners: hman Branches: F-11 F-12 InitialCC: mtasaka.u-tokyo.ac.jp Cvsextras Commits: yes
If you want to add me in CC list, please use my FAS name (mtasaka). By the way adding me in CC list is not strictly needed (but feel free to do so if you want). Also set fedora-cvs flag to ?.
New Package CVS Request ======================= Package Name: themonospot-base Short Description: Core component of Themonospot suite Owners: hman-it Branches: F-11 F-12 InitialCC: mtasaka Cvsextras Commits: yes
cvs done.
themonospot-base-0.8.2-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/themonospot-base-0.8.2-4.fc12
themonospot-base-0.8.2-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/themonospot-base-0.8.2-4.fc11
themonospot-base-0.8.2-4.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
themonospot-base-0.8.2-4.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Closing this one. Now you should be able to rebuild other themonospot-foo packges on F-11/12 (except for -gui-qt package)