Bug 557939
| Summary: | QMP: Full introspection support | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Luiz Capitulino <lcapitulino> | |
| Component: | qemu-kvm-rhev | Assignee: | Markus Armbruster <armbru> | |
| Status: | CLOSED ERRATA | QA Contact: | CongLi <coli> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | low | |||
| Version: | 7.0 | CC: | ailan, areis, armbru, berrange, gcosta, juzhang, knoel, lcapitulino, michen, ngu, qzhang, tburke, virt-maint, xiagao | |
| Target Milestone: | beta | |||
| Target Release: | --- | |||
| Hardware: | All | |||
| OS: | Linux | |||
| Whiteboard: | ||||
| Fixed In Version: | qemu-kvm-rhev-2.5.0-1.el7 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1283895 (view as bug list) | Environment: | ||
| Last Closed: | 2016-11-07 20:06:26 UTC | Type: | --- | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 559201, 580953, 643055, 693512, 821045, 950968, 1059069, 1283895 | |||
|
Description
Luiz Capitulino
2010-01-22 20:33:26 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux major release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Major release. This request is not yet committed for inclusion. Likely to be rhel7.0 material. Related bug 647516. Depends on upstream QAPI schema work. Moving to RHEL-7. *** Bug 963590 has been marked as a duplicate of this bug. *** Amos, it's interesting to note our original expectation for this feature. We don't need to dump errors anymore (this is not even possible today), but we certainly need to dump events. Two options: 1. Move events to the schema and dump them along 2. Extend query-events with argument information I prefer option 1, but you don't need to do this right now. IMO, it would be acceptable to work on command/types introspection first and after that add the events. send a draft patch to upstream: http://marc.info/?l=qemu-devel&m=137059998004419&w=2 *** Bug 953844 has been marked as a duplicate of this bug. *** Deferring to 7.1. It almost matured upstream, but not finished yet. Posted V4 to upstream: [Qemu-devel] [PATCH v4 0/5] QMP full introspection http://marc.info/?l=qemu-devel&m=139048842504757&w=2 *** Bug 647516 has been marked as a duplicate of this bug. *** Need to defer once again. Still not settled upstream. Need to simplify and clean the solution. Upstream goal is to crack the problem in the 2.4 development cycle, preferably early. [PATCH RFC 00/19] qapi: QMP introspection https://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg00342.html Since few RFC patches survive review unscathed, I have to reserve judgement on feasibility of a backport. Missed upstream 2.4, now on track for 2.5. http://lists.gnu.org/archive/html/qemu-devel/2015-09/msg01599.html No doc text needed, because direct use of QMP isn't supported. Hi Markus, I'm KVM QE. I noticed this bug is related to 32 patches, so I'm confused how to test it. Is it OK to run a loop of qmp cases? Could you pleas give some advice? Thanks, xiagao Please test QMP command
{ "execute": "query-qmp-schema" }
It should return an array of objects. Please test that.
If we had unlimited testing resources, I'd ask you to additionally
verify the objects make sense. We don't, and I'm not. Check the
return value is an array of objects, and call it a day. Okay?
Also consider adding this to the QMP test plan.
(In reply to Markus Armbruster from comment #27) > Please test QMP command > > { "execute": "query-qmp-schema" } > > It should return an array of objects. Please test that. > > If we had unlimited testing resources, I'd ask you to additionally > verify the objects make sense. We don't, and I'm not. Check the > return value is an array of objects, and call it a day. Okay? > > Also consider adding this to the QMP test plan. Thank you for quick reply:). It's okay for me. Verify this bug on:
qemu-kvm-rhev-2.6.0-20.el7.x86_64
Steps:
1. Run qemu with a qmp monitor.
# /usr/libexec/qemu-kvm -nodefaults -S -display none -qmp stdio
{"QMP": {"version": {"qemu": {"micro": 0, "minor": 6, "major": 2}, "package": " (qemu-kvm-rhev-2.6.0-20.el7)"}, "capabilities": []}}
{"execute": "qmp_capabilities"}
{"return": {}}
2. { "execute": "query-qmp-schema" }
Result is pass.
return an array of objects. Such as:
{"name": "344", "members": [{"name": "create-type", "type": "str"}, {"name": "cid", "type": "int"}, {"name": "parent-cid", "type": "int"}, {"name": "extents", "type": "[214]"}], "meta-type": "object"}, {"name": "345", "members": [{"name": "base", "type": "int"}, {"name": "limit", "type": "int"}], "meta-type": "object"}, {"name": "[214]", "element-type": "214", "meta-type": "array"}]}
Change the bug status to verified according to comment #29. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-2673.html |