Bug 558890

Summary:	Review Request: rubygem-icalendar - A ruby implementation of the iCalendar specification
Product:	[Fedora] Fedora	Reporter:	Mark Chappell <tremble>
Component:	Package Review	Assignee:	Mamoru TASAKA <mtasaka>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, mtasaka, notting, tremble
Target Milestone:	---	Flags:	mtasaka: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-02-05 16:52:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mark Chappell 2010-01-26 17:12:51 UTC

Spec URL: http://people.bath.ac.uk/ee0mdc/rpm/rubygem-icalendar/rubygem-icalendar.spec
SRPM URL: http://people.bath.ac.uk/ee0mdc/rpm/rubygem-icalendar/rubygem-icalendar-1.1.0-1.el5.src.rpm
Description:
Implements the iCalendar specification (RFC-2445) in Ruby.  This allows for
the generation and parsing of .ics files, which are used by a variety of
calendaring applications.

This one of my first packages, and I am seeking a sponsor

Comment 1 Mamoru TASAKA 2010-01-26 19:03:46 UTC

Some comments.
* For rpmlint messages, %global macro, unneeded macro, %check stage,
  please see bug 558824

* ruby(abi) dependency is missing
  https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines

* "GPL+ or Ruby" is better for license tag.

Comment 2 Mark Chappell 2010-01-27 14:41:53 UTC

Updated Specfile: http://people.bath.ac.uk/ee0mdc/rpm/rubygem-icalendar/rubygem-icalendar.spec
Updated SRPM: http://people.bath.ac.uk/ee0mdc/rpm/rubygem-icalendar/rubygem-icalendar-1.1.0-2.el5.src.rpm

* defines replaced by global
* unneeded macro removed
* check stage added (including patch to Rakefile so they run
* Requires: ruby(abi) added
* License: updated to "GPL+ or Ruby"
* Indentation - now consistently using spaces
* rpmlint now reports 4 errornious warnings, 3 about "misspelled-macro" that isn't a macro.  1 about a non-applied patch that is applied during install because I'm using gem to perform the install directly

Comment 3 Mark Chappell 2010-01-27 14:42:39 UTC

Correction - SRPM is 
http://people.bath.ac.uk/ee0mdc/rpm/rubygem-icalendar/rubygem-icalendar-1.1.0-2.fc12.src.rpm

Comment 4 Mamoru TASAKA 2010-01-27 17:51:26 UTC

Well,
- Use "BuildRequires: rubygem(rake)" instead of "BuildRequires: rubygem-rake"
  ref:
  https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides

Now this package itself is okay. I will wait for bug 558824
update before approving this package.

Comment 5 Mamoru TASAKA 2010-01-29 16:57:40 UTC

----------------------------------------------------------------
  This package (rubygem-icalendar) is APPROVED by mtasaka
----------------------------------------------------------------

Comment 6 Mark Chappell 2010-01-29 17:47:45 UTC

New Package CVS Request
=======================
Package Name: rubygem-icalendar
Short Description: A ruby implementation of the iCalendar specification
Owners: tremble
Branches: F-11 F-12 EL-5

Comment 7 Kevin Fenzi 2010-01-31 19:05:50 UTC

CVS done (by process-cvs-requests.py).

Comment 8 Fedora Update System 2010-02-01 15:55:04 UTC

rubygem-icalendar-1.1.0-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/rubygem-icalendar-1.1.0-3.fc12

Comment 9 Mamoru TASAKA 2010-02-02 17:14:13 UTC

Please build this also for devel (and F-11 if you want)

Comment 10 Mamoru TASAKA 2010-02-05 16:52:42 UTC

Closing.

Comment 11 Fedora Update System 2010-02-20 00:12:06 UTC

rubygem-icalendar-1.1.0-3.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.