Bug 558890 - Review Request: rubygem-icalendar - A ruby implementation of the iCalendar specification
Summary: Review Request: rubygem-icalendar - A ruby implementation of the iCalendar sp...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-01-26 17:12 UTC by Mark Chappell
Modified: 2010-02-20 00:12 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-02-05 16:52:42 UTC
Type: ---
Embargoed:
mtasaka: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Mark Chappell 2010-01-26 17:12:51 UTC
Spec URL: http://people.bath.ac.uk/ee0mdc/rpm/rubygem-icalendar/rubygem-icalendar.spec
SRPM URL: http://people.bath.ac.uk/ee0mdc/rpm/rubygem-icalendar/rubygem-icalendar-1.1.0-1.el5.src.rpm
Description:
Implements the iCalendar specification (RFC-2445) in Ruby.  This allows for
the generation and parsing of .ics files, which are used by a variety of
calendaring applications.

This one of my first packages, and I am seeking a sponsor

Comment 1 Mamoru TASAKA 2010-01-26 19:03:46 UTC
Some comments.
* For rpmlint messages, %global macro, unneeded macro, %check stage,
  please see bug 558824

* ruby(abi) dependency is missing
  https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines

* "GPL+ or Ruby" is better for license tag.

Comment 2 Mark Chappell 2010-01-27 14:41:53 UTC
Updated Specfile: http://people.bath.ac.uk/ee0mdc/rpm/rubygem-icalendar/rubygem-icalendar.spec
Updated SRPM: http://people.bath.ac.uk/ee0mdc/rpm/rubygem-icalendar/rubygem-icalendar-1.1.0-2.el5.src.rpm

* defines replaced by global
* unneeded macro removed
* check stage added (including patch to Rakefile so they run
* Requires: ruby(abi) added
* License: updated to "GPL+ or Ruby"
* Indentation - now consistently using spaces
* rpmlint now reports 4 errornious warnings, 3 about "misspelled-macro" that isn't a macro.  1 about a non-applied patch that is applied during install because I'm using gem to perform the install directly

Comment 4 Mamoru TASAKA 2010-01-27 17:51:26 UTC
Well,
- Use "BuildRequires: rubygem(rake)" instead of "BuildRequires: rubygem-rake"
  ref:
  https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides

Now this package itself is okay. I will wait for bug 558824
update before approving this package.

Comment 5 Mamoru TASAKA 2010-01-29 16:57:40 UTC
----------------------------------------------------------------
  This package (rubygem-icalendar) is APPROVED by mtasaka
----------------------------------------------------------------

Comment 6 Mark Chappell 2010-01-29 17:47:45 UTC
New Package CVS Request
=======================
Package Name: rubygem-icalendar
Short Description: A ruby implementation of the iCalendar specification
Owners: tremble
Branches: F-11 F-12 EL-5

Comment 7 Kevin Fenzi 2010-01-31 19:05:50 UTC
CVS done (by process-cvs-requests.py).

Comment 8 Fedora Update System 2010-02-01 15:55:04 UTC
rubygem-icalendar-1.1.0-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/rubygem-icalendar-1.1.0-3.fc12

Comment 9 Mamoru TASAKA 2010-02-02 17:14:13 UTC
Please build this also for devel (and F-11 if you want)

Comment 10 Mamoru TASAKA 2010-02-05 16:52:42 UTC
Closing.

Comment 11 Fedora Update System 2010-02-20 00:12:06 UTC
rubygem-icalendar-1.1.0-3.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.