Bug 562097
| Summary: | Rename request: libsocialweb - A social network data aggregator | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Robinson <pbrobinson> |
| Component: | Package Review | Assignee: | Michel Lind <michel> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | christoph.wickert, fedora-package-review, michel, notting |
| Target Milestone: | --- | Flags: | michel:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-05-23 21:34:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 538447 | ||
|
Description
Peter Robinson
2010-02-05 08:36:32 UTC
Updated to the 0.24.0 release SPEC: http://pbrobinson.fedorapeople.org/libsocialweb.spec SRPM: http://pbrobinson.fedorapeople.org/libsocialweb-0.24.0-1.fc12.src.rpm I did a diff to the current mojito.spec from the development branch, and the diff looks reasonable -- though there are some oddities:
(for main package)
+%{_libdir}/libsocialweb*.0 .2
+%{_libdir}/libsocialweb*.1
won't libsocialweb*.so.* be clearer -- and won't break when they bump the soname?
(for devel)
+%{_libdir}/libsocialweb*so
likewise here -- libsocialweb*.so is probably more canonical
Agreed. Will update. Here's the full review. The license need to be reverted to what mojito has (but with LGPLv2, not LGPLv2.1 -- see http://fedoraproject.org/wiki/Licensing#Good_Licenses And if you could locate a source tarball now that moblin.org is down, and update the SRPM, I could approve the review. Review ====== Problems -------- rpmlint: only one real warning, the invalid URL. Change to new MeeGo URL when committing $ rpmlint libsocialweb-0.24.0-1.fc12.src.rpm ~/Downloads/libsocialweb* libsocialweb.src: W: spelling-error Summary(en_US) aggregator -> aggregation, aggregate, aggressor libsocialweb.src: W: invalid-url Source0: http://download.moblin.org/sources/libsocialweb/0.24/libsocialweb-0.24.0.tar.bz2 HTTP Error 404: Not Found libsocialweb.x86_64: W: spelling-error Summary(en_US) aggregator -> aggregation, aggregate, aggressor 4 packages and 0 specfiles checked; 0 errors, 3 warnings. License accurate: FIX -- a spot check shows that many files are LGPLv2 without any mention of using any later version. Upstream source: FIX -- can't check until MeeGo downloads available Passes ------ Package & spec names: OK Fit for inclusion: OK (rename of existing mojito) Content: OK License acceptable: OK License included: OK Spec language: OK (US English, legible) Compiles: OK see http://koji.fedoraproject.org/koji/taskinfo?taskID=2087590 Complete BRs: OK Locale: OK ldconfig: OK no bundled libs: OK Dir ownership: OK No dup files: OK File perms: OK UTF-8 files: OK %clean: OK rm on %install: OK Consistent macros: OK Large docs: NA %doc unessential: OK Headers in -devel: OK *.so.* -> *.so in -devel: OK Static in -static: NA -devel Req: main: OK No .la: OK Desktop files: NA If this is a renamed mojito, it needs Provides:/Obsoltes: for it. See http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Renaming.2Freplacing_existing_packages (In reply to comment #5) > If this is a renamed mojito, it needs Provides:/Obsoltes: for it. See > http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Renaming.2Freplacing_existing_packages That is known. See note in comment 1 OK. We're on again. We have a git repo of the code! So updated.... SPEC: http://pbrobinson.fedorapeople.org/libsocialweb.spec SRPM: http://pbrobinson.fedorapeople.org/libsocialweb-0.24.8-1.fc13.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2182111 Everything looks fine. APPROVED. As a side note, if libsocialweb is not source-compatible with mojito (as in mojito-dependent packages could be rebuilt to depend on it), then I don't see why a Provides/Obsoletes needs to be added at all. (In reply to comment #8) > Everything looks fine. APPROVED. Thanks > As a side note, if libsocialweb is not source-compatible with mojito (as in > mojito-dependent packages could be rebuilt to depend on it), then I don't see > why a Provides/Obsoletes needs to be added at all. It will primarily be enable clean upgrades due to packages that currently depend on mojito will depend on l-s-w so we don't leave mojito around. New Package CVS Request ======================= Package Name: libsocialweb Short Description: A social network data aggregator Owners: pbrobinson Branches: F-13 InitialCC: CVS done (by process-cvs-requests.py). Built and in rawhide. Thanks |