Hide Forgot
SPEC: http://pbrobinson.fedorapeople.org/mojito.spec SRPM: http://pbrobinson.fedorapeople.org/mojito-0.10.3-1.fc11.src.rpm Mojito is a social data server which will fetch data from the "social web", such as your friend's blog posts and photos, upcoming events, recently played tracks, and pending eBay* auctions. It also provides a service to update your status on web services which support it, such as MySpace* and Twitter*.
Mock build failed: checking for GCONF... configure: error: Package requirements (gconf-2.0) were not met: No package 'gconf-2.0' found Please fix this and update the srpm and spec.
http://koji.fedoraproject.org/koji/taskinfo?taskID=1427658 SPEC: same link as before SRPM: http://pbrobinson.fedorapeople.org/mojito-0.10.3-2.fc11.src.rpm Updated. Added NetworkManager as well.
Any update?
$ rpm -i mojito-0.10.3-2.fc11.src.rpm warning: user perobinson does not exist - using root warning: group perobinson does not exist - using root warning: user perobinson does not exist - using root warning: group perobinson does not exist - using root Did you build it as root?
> Did you build it as root? No, there's no need to build it as root, I don't do anything as root. That's a standard warning of no consequence.
I'm releasing the review. I'm in the eye of some s**t storm at work.
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1452075 - rpmlint is NOT silent for SRPM and for RPM. mojito.src: W: invalid-license LGPLv2.1 mojito.i586: W: invalid-license LGPLv2.1 mojito-devel.i586: W: invalid-license LGPLv2.1 == Fix it to LGPLv2 + source files match upstream url 6fcc6b5b439bd95d18901aa2ee7f2241e381a02a mojito-0.10.3.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + mojito-client.pc and mojito-module.pc files present. + -devel subpackage present. + no .la files. + no translations are available + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package mojito-0.10.3-2.fc12.i586 => Provides: libmojito-client.so.1 libmojito-service-dummy.so libmojito.so.0 libtwitter.so Requires(interp): /sbin/ldconfig /sbin/ldconfig Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libdbus-1.so.3 libdbus-glib-1.so.2 libgconf-2.so.4 libgdk_pixbuf-2.0.so.0 libgio-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgobject-2.0.so.0 libgthread-2.0.so.0 libjson-glib-1.0.so.0 libmojito-client.so.1 libmojito.so.0 libpthread.so.0 librt.so.1 libsoup-2.4.so.1 libsoup-gnome-2.4.so.1 libtwitter-glib-1.0.so.0 rtld(GNU_HASH) + Package mojito-devel-0.10.3-2.fc12.i586 => Provides: pkgconfig(mojito-client) = 0.10.3 pkgconfig(mojito-module) = 0.10.3 Requires: /usr/bin/pkg-config libmojito-client.so.1 libmojito.so.0 pkgconfig(dbus-glib-1) pkgconfig(glib-2.0) pkgconfig(libsoup-2.4) + Not a GUI application Should: 1) Fix rpmlint warnings. 2) you can also add examples and tests sample code to %doc of -devel package as %doc tests/*.c examples/*c examples/*.py APPROVED.
3) and also remove following from SPEC BuildRequires: gnome-keyring-devel BuildRequires: libsoup-devel because glib2-devel will pull those in buildroot. See successful build after removing those BRs http://koji.fedoraproject.org/koji/taskinfo?taskID=1452185 4)forgot to tell that you will also need to chmod 644 examples/*.py in %prep section to make rpmlint silent.
Brilliant. I'll update the spec before I push it to cvs. Thanks!
New Package CVS Request ======================= Package Name: mojito Short Description: A social network data aggregator Owners: pbrobinson Branches: F-11 F-10 InitialCC:
cvs done.
Imported, built in rawhide. Updated to the latest release and added in support for languages and the new backends. Thanks for the review.
(In reply to comment #8) > 3) and also remove following from SPEC > BuildRequires: gnome-keyring-devel > BuildRequires: libsoup-devel > > because glib2-devel will pull those in buildroot. See successful build after > removing those BRs > http://koji.fedoraproject.org/koji/taskinfo?taskID=1452185 Actually that should be the other way around. glib2-devel would be pulled in by gnome-keyring-devel. See failed build here http://koji.fedoraproject.org/koji/getfile?taskID=1456399&name=build.log
I got successful build http://koji.fedoraproject.org/koji/taskinfo?taskID=1456571, with following in SPEC BuildRequires: dbus-glib-devel BuildRequires: glib2-devel BuildRequires: GConf2-devel BuildRequires: NetworkManager-devel BuildRequires: pkgconfig BuildRequires: rest-devel BuildRequires: twitter-glib-devel BuildRequires: intltool BuildRequires: gtk-doc
(In reply to comment #14) > I got successful build > http://koji.fedoraproject.org/koji/taskinfo?taskID=1456571, > > with following in SPEC > BuildRequires: dbus-glib-devel > BuildRequires: glib2-devel > BuildRequires: GConf2-devel > BuildRequires: NetworkManager-devel > BuildRequires: pkgconfig > BuildRequires: rest-devel > BuildRequires: twitter-glib-devel > BuildRequires: intltool > BuildRequires: gtk-doc I don't think the 0.10 version explicitly depended on them and hence still built fine without the feature but the later version does add an explicit dependency on a couple of packages. NetworkManager-glib-devel was another one of those.
Built and pushed to rawhide.