Red Hat Bugzilla – Bug 562097
Rename request: libsocialweb - A social network data aggregator
Last modified: 2010-05-23 17:34:00 EDT
libsocialweb is a social data server which fetches data from the "social web",
such as your friend's blog posts and photos, upcoming events, recently played
tracks, and pending eBay* auctions. It also provides a service to update
your status on web services which support it, such as MySpace* and Twitter*.
Original package review was https://bugzilla.redhat.com/show_bug.cgi?id=506486
Note Obsoletes/Provides not added as yet as some packages still depend on mojito. The transition will be complete by late March early April in time for the final Moblin 2.2
Updated to the 0.24.0 release
I did a diff to the current mojito.spec from the development branch, and the diff looks reasonable -- though there are some oddities:
(for main package)
won't libsocialweb*.so.* be clearer -- and won't break when they bump the soname?
likewise here -- libsocialweb*.so is probably more canonical
Agreed. Will update.
Here's the full review. The license need to be reverted to what mojito has (but with LGPLv2, not LGPLv2.1 --
And if you could locate a source tarball now that moblin.org is down, and update the SRPM, I could approve the review.
rpmlint: only one real warning, the invalid URL. Change to new MeeGo URL when committing
$ rpmlint libsocialweb-0.24.0-1.fc12.src.rpm ~/Downloads/libsocialweb*
libsocialweb.src: W: spelling-error Summary(en_US) aggregator -> aggregation, aggregate, aggressor
libsocialweb.src: W: invalid-url Source0: http://download.moblin.org/sources/libsocialweb/0.24/libsocialweb-0.24.0.tar.bz2 HTTP Error 404: Not Found
libsocialweb.x86_64: W: spelling-error Summary(en_US) aggregator -> aggregation, aggregate, aggressor
4 packages and 0 specfiles checked; 0 errors, 3 warnings.
License accurate: FIX -- a spot check shows that many files are LGPLv2
without any mention of using any later version.
Upstream source: FIX -- can't check until MeeGo downloads available
Package & spec names: OK
Fit for inclusion: OK (rename of existing mojito)
License acceptable: OK
License included: OK
Spec language: OK (US English, legible)
Complete BRs: OK
no bundled libs: OK
Dir ownership: OK
No dup files: OK
File perms: OK
UTF-8 files: OK
rm on %install: OK
Consistent macros: OK
Large docs: NA
%doc unessential: OK
Headers in -devel: OK
*.so.* -> *.so in -devel: OK
Static in -static: NA
-devel Req: main: OK
No .la: OK
Desktop files: NA
If this is a renamed mojito, it needs Provides:/Obsoltes: for it. See
(In reply to comment #5)
> If this is a renamed mojito, it needs Provides:/Obsoltes: for it. See
That is known. See note in comment 1
OK. We're on again. We have a git repo of the code! So updated....
Everything looks fine. APPROVED.
As a side note, if libsocialweb is not source-compatible with mojito (as in mojito-dependent packages could be rebuilt to depend on it), then I don't see why a Provides/Obsoletes needs to be added at all.
(In reply to comment #8)
> Everything looks fine. APPROVED.
> As a side note, if libsocialweb is not source-compatible with mojito (as in
> mojito-dependent packages could be rebuilt to depend on it), then I don't see
> why a Provides/Obsoletes needs to be added at all.
It will primarily be enable clean upgrades due to packages that currently depend on mojito will depend on l-s-w so we don't leave mojito around.
New Package CVS Request
Package Name: libsocialweb
Short Description: A social network data aggregator
CVS done (by process-cvs-requests.py).
Built and in rawhide. Thanks