Bug 562993
| Summary: | Review Request: rubygem-yard - Documentation tool for consistent and usable documentation in Ruby | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mo Morsi <mmorsi> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mastahnke, mtasaka, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
tcallawa: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-03-12 16:27:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 562998 | ||
|
Description
Mo Morsi
2010-02-08 23:49:01 UTC
Some notes:
* Macros
- Defined %ruby_sitelib is used nowhere
- Please use defined %geminstdir also in %files
* ruby(abi) dependency
- "Requires: ruby(abi) = 1.8" dependency is missing
https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines
* License
--------------------------------------------------------
Overall: MIT
GPLv2 or Ruby
./lib/yard/parser/c_parser.rb
--------------------------------------------------------
- License tag should be "MIT and (GPLv2 or Ruby)".
* SourceURL
- We usually use http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem
* Documents
- "ChangeLog", "LICENSE", "README.md" under %geminstdir should properly be
marked as %doc (and we usually also mark Rakefile as %doc)
- Also benckmarks/ docs/ spec/ templates/ directories can be marked
as %doc
(and please consider to split these files/directories into -doc
subpackage)
* %check
- As this package contains spec/ directory, please add %check section
and execute some test program (like $ rake spec) there.
(In reply to comment #1) > Some notes: > > * Macros > - Defined %ruby_sitelib is used nowhere > - Please use defined %geminstdir also in %files Done > > * ruby(abi) dependency > - "Requires: ruby(abi) = 1.8" dependency is missing > https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines Done > > * License > -------------------------------------------------------- > Overall: MIT > > GPLv2 or Ruby > ./lib/yard/parser/c_parser.rb > -------------------------------------------------------- > - License tag should be "MIT and (GPLv2 or Ruby)". Done > > * SourceURL > - We usually use http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem gemcutter has recently replaced rubyforge as the default/official rubygem gem hosting location and thus I'm thinking we should get all our rubygem packages from there from now on http://update.gemcutter.org/2009/10/26/transition.html > > * Documents > - "ChangeLog", "LICENSE", "README.md" under %geminstdir should properly be > marked as %doc (and we usually also mark Rakefile as %doc) > - Also benckmarks/ docs/ spec/ templates/ directories can be marked > as %doc > (and please consider to split these files/directories into -doc > subpackage) > > * %check > - As this package contains spec/ directory, please add %check section > and execute some test program (like $ rake spec) there. Both done Updated and uploaded new rubygem-yard rpm Spec URL: http://mo.morsi.org/files/gems/rubygem-yard.spec SRPM URL: http://mo.morsi.org/files/gems/rubygem-yard-0.5.3-2.fc12.src.rpm (In reply to comment #2) > (In reply to comment #1) > > * SourceURL > > - We usually use http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem > > gemcutter has recently replaced rubyforge as the default/official rubygem gem > hosting location and thus I'm thinking we should get all our rubygem packages > from there from now on Thank you for information. For -2: * BR (BuildRequires) - Please use "BR: rubygem(rake)" style. ref: https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides ? %check $ rake spec observes 1 test failure. Is this safe to ignore? (If patches to fix this failure is available, please apply) * Directory ownership issue - The directory %geminstdir itself is not owned by any packages. https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes (In reply to comment #3) > For -2: > * BR (BuildRequires) > - Please use "BR: rubygem(rake)" style. ref: > https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides > > ? %check > $ rake spec observes 1 test failure. Is this safe to ignore? > (If patches to fix this failure is available, please apply) Was due to a missing dependency. > > * Directory ownership issue > - The directory %geminstdir itself is not owned by any packages. > https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes All three issues are resolved. Updated and uploaded new rubygem-yard spec / srpm Spec URL: http://mo.morsi.org/files/gems/rubygem-yard.spec SRPM URL: http://mo.morsi.org/files/gems/rubygem-yard-0.5.3-3.fc12.src.rpm ----------------------------------------------------------- This package (rubygem-yard) is APPROVED by mtasaka ----------------------------------------------------------- New Package CVS Request ======================= Package Name: rubygem-yard Short Description: Tool for consistent and usable documentation in Ruby Owners: mmorsi Branches: F-12, F-13 InitialCC: CVS done (by process-cvs-requests.py). Closing. Would you like to branch this for EPEL? If you'd rather not maintain it, I'd be happy to. I wasn't planning on it, so feel free to go for it. Package Change Request ====================== Package Name: rubygem-yard New Branches: el5 el6 Owners: stahnma InitialCC: See comment 10. Git done (by process-git-requests). |