Spec URL: http://mo.morsi.org/files/gems/rubygem-yard.spec SRPM URL: http://mo.morsi.org/files/gems/rubygem-yard-0.5.3-1.fc12.src.rpm Description: YARD is a documentation generation tool for the Ruby programming language. It enables the user to generate consistent, usable documentation that can be exported to a number of formats very easily, and also supports extending for custom Ruby constructs such as custom class level definitions. rpmlint rpmbuild/RPMS/noarch/rubygem-yard-0.5.3-1.fc12.noarch.rpm rubygem-yard.noarch: W: no-documentation gem build process fails to build rdoc/ri due to what seems to be error when parsing code for docs. Nothing can be done to generate docs while maintaining all necessary code so for full rubygem-operation. rubygem-yard.noarch: W: hidden-file-or-dir /usr/lib/ruby/gems/1.8/gems/yard-0.5.3/.yardopts This file is necessary / used by rubygem-yard 1 packages and 0 specfiles checked; 0 errors, 2 warnings. rpmlint rpmbuild/SRPMS/rubygem-yard-0.5.3-1.fc12.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1970412
Some notes: * Macros - Defined %ruby_sitelib is used nowhere - Please use defined %geminstdir also in %files * ruby(abi) dependency - "Requires: ruby(abi) = 1.8" dependency is missing https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines * License -------------------------------------------------------- Overall: MIT GPLv2 or Ruby ./lib/yard/parser/c_parser.rb -------------------------------------------------------- - License tag should be "MIT and (GPLv2 or Ruby)". * SourceURL - We usually use http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem * Documents - "ChangeLog", "LICENSE", "README.md" under %geminstdir should properly be marked as %doc (and we usually also mark Rakefile as %doc) - Also benckmarks/ docs/ spec/ templates/ directories can be marked as %doc (and please consider to split these files/directories into -doc subpackage) * %check - As this package contains spec/ directory, please add %check section and execute some test program (like $ rake spec) there.
(In reply to comment #1) > Some notes: > > * Macros > - Defined %ruby_sitelib is used nowhere > - Please use defined %geminstdir also in %files Done > > * ruby(abi) dependency > - "Requires: ruby(abi) = 1.8" dependency is missing > https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines Done > > * License > -------------------------------------------------------- > Overall: MIT > > GPLv2 or Ruby > ./lib/yard/parser/c_parser.rb > -------------------------------------------------------- > - License tag should be "MIT and (GPLv2 or Ruby)". Done > > * SourceURL > - We usually use http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem gemcutter has recently replaced rubyforge as the default/official rubygem gem hosting location and thus I'm thinking we should get all our rubygem packages from there from now on http://update.gemcutter.org/2009/10/26/transition.html > > * Documents > - "ChangeLog", "LICENSE", "README.md" under %geminstdir should properly be > marked as %doc (and we usually also mark Rakefile as %doc) > - Also benckmarks/ docs/ spec/ templates/ directories can be marked > as %doc > (and please consider to split these files/directories into -doc > subpackage) > > * %check > - As this package contains spec/ directory, please add %check section > and execute some test program (like $ rake spec) there. Both done Updated and uploaded new rubygem-yard rpm Spec URL: http://mo.morsi.org/files/gems/rubygem-yard.spec SRPM URL: http://mo.morsi.org/files/gems/rubygem-yard-0.5.3-2.fc12.src.rpm
(In reply to comment #2) > (In reply to comment #1) > > * SourceURL > > - We usually use http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem > > gemcutter has recently replaced rubyforge as the default/official rubygem gem > hosting location and thus I'm thinking we should get all our rubygem packages > from there from now on Thank you for information. For -2: * BR (BuildRequires) - Please use "BR: rubygem(rake)" style. ref: https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides ? %check $ rake spec observes 1 test failure. Is this safe to ignore? (If patches to fix this failure is available, please apply) * Directory ownership issue - The directory %geminstdir itself is not owned by any packages. https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes
(In reply to comment #3) > For -2: > * BR (BuildRequires) > - Please use "BR: rubygem(rake)" style. ref: > https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides > > ? %check > $ rake spec observes 1 test failure. Is this safe to ignore? > (If patches to fix this failure is available, please apply) Was due to a missing dependency. > > * Directory ownership issue > - The directory %geminstdir itself is not owned by any packages. > https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes All three issues are resolved. Updated and uploaded new rubygem-yard spec / srpm Spec URL: http://mo.morsi.org/files/gems/rubygem-yard.spec SRPM URL: http://mo.morsi.org/files/gems/rubygem-yard-0.5.3-3.fc12.src.rpm
----------------------------------------------------------- This package (rubygem-yard) is APPROVED by mtasaka -----------------------------------------------------------
New Package CVS Request ======================= Package Name: rubygem-yard Short Description: Tool for consistent and usable documentation in Ruby Owners: mmorsi Branches: F-12, F-13 InitialCC:
CVS done (by process-cvs-requests.py).
Closing.
Would you like to branch this for EPEL? If you'd rather not maintain it, I'd be happy to.
I wasn't planning on it, so feel free to go for it.
Package Change Request ====================== Package Name: rubygem-yard New Branches: el5 el6 Owners: stahnma InitialCC: See comment 10.
Git done (by process-git-requests).