Bug 562997
| Summary: | Review Request: rubygem-maruku - Markdown-superset interpreter written in Ruby | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mo Morsi <mmorsi> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mtasaka, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-03-17 07:41:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 562992 | ||
| Bug Blocks: | 562998 | ||
|
Description
Mo Morsi
2010-02-09 00:06:10 UTC
Some notes: - License tag should be "GPLv2+". - For other issues - unused / unneeded macros - URL - ruby(abi) dependency - marking %doc - enabling %check (as this contains tests/ directory) Please check my comment on bug 562993 . (In reply to comment #1) > Some notes: > - License tag should be "GPLv2+". Done > - For other issues > - unused / unneeded macros Done > - URL See my comment reply on bug 562993 > - ruby(abi) dependency > - marking %doc > - enabling %check (as this contains tests/ directory) All done > Please check my comment on bug 562993 . Updated and uploaded new rubygem-maruku rpm Spec URL: http://mo.morsi.org/files/gems/rubygem-maruku.spec SRPM URL: http://mo.morsi.org/files/gems/rubygem-maruku-0.6.0-2.fc12.src.rpm Please address - directory ownership issue - rake test failure (at least BR: rubygem(rake) is needed. Also it seems "Gem::manage_gems" in Rakefile seems deprecated) (In reply to comment #3) > Please address > - directory ownership issue > - rake test failure (at least BR: rubygem(rake) is needed. > Also it seems "Gem::manage_gems" in Rakefile seems deprecated) All three issues are resolved. Updated and uploaded new rubygem-maruku spec / srpm Spec URL: http://mo.morsi.org/files/gems/rubygem-maruku.spec SRPM URL: http://mo.morsi.org/files/gems/rubygem-maruku-0.6.0-3.fc12.src.rpm There are a few tests that fail when rake test is run, though the majority pass. The same tests fail when I install the upstream gem via the normal 'gem install' means and run rake test in the default installation dir. Well, after checking the whole source code, I cannot figure out under what license this gem is distributed under. Perhaps under GPLv2+, however - Overall license text could not be found - especially I cannot figure out under what licenses scripts under bin/ directory are. Would you ask the upstream? Maruku is licensed under the GPLv2+ http://github.com/nex3/maruku/blob/master/LICENSE Thus the current specfile should be good in that respect. Okay. -------------------------------------------------------- This package (rubygem-maruku) is APPROVED by mtasaka -------------------------------------------------------- New Package CVS Request ======================= Package Name: rubygem-maruku Short Description: A Markdown interpreter in Ruby. Owners: mmorsi Branches: F-12, F-13 InitialCC: CVS done (by process-cvs-requests.py). Closing. |