Bug 579639

Summary: SuperTux bundles Squirrel
Product: [Fedora] Fedora Reporter: Matt McCutchen <matt>
Component: supertuxAssignee: Steven Pritchard <steve>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 12CC: dan, steve
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: supertux-0.3.3-1.fc14 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-04-15 07:31:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 504493    
Attachments:
Description Flags
SuperTux changes to squirrel none

Description Matt McCutchen 2010-04-06 05:57:44 UTC 
Description of problem:
SuperTux bundles a Squirrel interpreter.  It shouldn't.

https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries

Version-Release number of selected component (if applicable):
supertux-0.3.1-9.fc12

Steps to Reproduce:
yumdownloader --source supertux
rpmdev-extract supertux-*.src.rpm
tar -tvf supertux-*.src/supertux-*.tar* | grep squirrel/
Comment 1 Matt McCutchen 2010-04-06 05:58:28 UTC 
It looks like this may be addressed along with bug 575533.
Comment 2 Dan Horák 2010-04-06 06:34:49 UTC 
Please check if this is an unmodified copy of squirrel, people quite often make API incompatible improvements to squirrel.
Comment 3 Matt McCutchen 2010-04-14 07:17:07 UTC 
The modifications are unimportant.  It looks like SuperTux was successfully built against the system Squirrel:

https://koji.fedoraproject.org/koji/buildinfo?buildID=165815
Comment 4 Dan Horák 2010-04-14 09:49:12 UTC 
(In reply to comment #3)
> The modifications are unimportant.  It looks like SuperTux was successfully
> built against the system Squirrel:

Can you post the diff somewhere?
Comment 5 Matt McCutchen 2010-04-15 06:13:36 UTC 
Created attachment 406681 [details]
SuperTux changes to squirrel

Here is the diff.  It consists of two changes.

- Adding a missing const.  Accepted upstream, but there is no publicly viewable repository (ugh):
http://squirrel-lang.org/forums/thread/3632.aspx

- A change to word size determination that was proposed upstream but got no response:
http://squirrel-lang.org/forums/thread/3633.aspx
Comment 6 Dan Horák 2010-04-15 07:31:15 UTC 
Thanks, they looks harmless. Closing because the rawhide package already uses system squirrel.