Bug 580681

Summary: Review Request: libdshconfig - Configuration file parser library for dsh
Product: [Fedora] Fedora Reporter: Damien Durand <splinux25>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, martin.gieseking, notting
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-09-14 10:58:49 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 580744    

Description Damien Durand 2010-04-08 18:53:38 UTC 
Spec URL: http://splinux.fedorapeople.org/libdshconfig/libdshconfig.spec
SRPM URL: http://splinux.fedorapeople.org/libdshconfig/libdshconfig-0.20.9-1.fc13.src.rpm

Description: Runtime library for configuration file parser, required 
for running programs with dsh config file support.
Comment 1 Martin Gieseking 2010-06-15 19:35:46 UTC 
Hi Damien,

the package looks almost fine to me. Just two suggestions:

- The tarball contains a couple of tests which should be executed in a %check section (with "make check").

- be more specific in the %files sections:
  %{_includedir}/*   =>  %{_includedir}/%{name}.h
  %{_libdir}/*.so.*  =>  %{_libdir}/%{name}.so.*
  %{_libdir}/*.so    =>  %{_libdir}/%{name}.so