Spec URL: http://splinux.fedorapeople.org/dsh/dsh.spec SRPM URL: http://splinux.fedorapeople.org/dsh/dsh-0.25.9-4.src.rpm Description: Distributed shell. Runs command through rsh or ssh on a cluster of machines. libdshconfig is needed to build this package, there is a review here : https://bugzilla.redhat.com/show_bug.cgi?id=580681
Hi Damien, here are a couple of initial comments: - the above SPEC and SRPM are out of sync (spec files differ) - change %{?disttag} to %{?dist} in the Release field - The tarball contains a copy of gettext. You should remove it and use the correspondent Fedora package instead. Some additional patching might be necessary. - The tarball contains several tests. It's probably a good idea to run them (in a %check section). - The changelog seems to be incomplete. Some releases are not listed, e.g. 0.25.9-1, -2, -3. - The header format of the changelog entries should be consistent.
Another cosmetic issue: - delete the final dot from the summary $ rpmlint dsh-* dsh.i686: W: summary-ended-with-dot C Run a single command on many hosts. dsh.i686: W: spelling-error %description -l en_US rsh -> rah, rs, sh 2 packages and 0 specfiles checked; 0 errors, 2 warnings.
Damien, what's the status of this package?
Hello I'm closing this review... I don't work on this package.