Bug 580681 - Review Request: libdshconfig - Configuration file parser library for dsh
Summary: Review Request: libdshconfig - Configuration file parser library for dsh
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 580744
TreeView+ depends on / blocked
 
Reported: 2010-04-08 18:53 UTC by Damien Durand
Modified: 2010-09-14 10:58 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-09-14 10:58:49 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description Damien Durand 2010-04-08 18:53:38 UTC 
Spec URL: http://splinux.fedorapeople.org/libdshconfig/libdshconfig.spec
SRPM URL: http://splinux.fedorapeople.org/libdshconfig/libdshconfig-0.20.9-1.fc13.src.rpm

Description: Runtime library for configuration file parser, required 
for running programs with dsh config file support.
Comment 1 Martin Gieseking 2010-06-15 19:35:46 UTC 
Hi Damien,

the package looks almost fine to me. Just two suggestions:

- The tarball contains a couple of tests which should be executed in a %check section (with "make check").

- be more specific in the %files sections:
  %{_includedir}/*   =>  %{_includedir}/%{name}.h
  %{_libdir}/*.so.*  =>  %{_libdir}/%{name}.so.*
  %{_libdir}/*.so    =>  %{_libdir}/%{name}.so
Note You need to log in before you can comment on or make changes to this bug.