Bug 580744

Summary:	Review Request: dsh - Run a single command on many hosts.
Product:	[Fedora] Fedora	Reporter:	Damien Durand <splinux25>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, martin.gieseking, notting, pahan, sander, slukasik
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-09-14 10:55:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	580681
Bug Blocks:

Description Damien Durand 2010-04-08 22:46:21 UTC

Spec URL: http://splinux.fedorapeople.org/dsh/dsh.spec
SRPM URL: http://splinux.fedorapeople.org/dsh/dsh-0.25.9-4.src.rpm

Description: Distributed shell. Runs command through rsh or ssh on a cluster of
machines.


libdshconfig is needed to build this package, there is a review here : https://bugzilla.redhat.com/show_bug.cgi?id=580681

Comment 1 Martin Gieseking 2010-04-09 12:36:25 UTC

Hi Damien,

here are a couple of initial comments:

- the above SPEC and SRPM are out of sync (spec files differ)

- change %{?disttag} to %{?dist} in the Release field

- The tarball contains a copy of gettext. You should remove it and use the correspondent Fedora package instead. Some additional patching might be necessary.

- The tarball contains several tests. It's probably a good idea to run them (in a %check section).

- The changelog seems to be incomplete. Some releases are not listed, e.g. 0.25.9-1, -2, -3.

- The header format of the changelog entries should be consistent.

Comment 2 Martin Gieseking 2010-04-09 12:50:44 UTC

Another cosmetic issue:
- delete the final dot from the summary

$ rpmlint dsh-*
dsh.i686: W: summary-ended-with-dot C Run a single command on many hosts.
dsh.i686: W: spelling-error %description -l en_US rsh -> rah, rs, sh
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Comment 3 Martin Gieseking 2010-08-31 15:02:52 UTC

Damien, what's the status of this package?

Comment 4 Damien Durand 2010-09-14 10:55:29 UTC

Hello

I'm closing this review... I don't work on this package.