Bug 598460
| Summary: | [PATCH] rb-site crashes when finishing | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Rintel <lkundrak> | ||||
| Component: | ReviewBoard | Assignee: | Stephen Gallagher <sgallagh> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 13 | CC: | dmalcolm, dyoung, leifer, sgallagh | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | ReviewBoard-1.0.9-6.fc13 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2010-09-04 04:54:15 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
This is a bug due to an incompatibility with Django 1.2. I am going to be updating ReviewBoard in Fedora 13 to 1.0.8 shortly, which includes this fix. ReviewBoard-1.0.8-5.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/ReviewBoard-1.0.8-5.fc13 *** Bug 616578 has been marked as a duplicate of this bug. *** ReviewBoard-1.0.8-5.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. How did this get pushed to stable? rb-site requires a version of python-djblets that's not in F13 stable?
$ sudo rb-site install /var/www/reviews
Traceback (most recent call last):
File "/usr/bin/rb-site", line 5, in <module>
from pkg_resources import load_entry_point
File "/usr/lib/python2.6/site-packages/pkg_resources.py", line 2675, in <module>
parse_requirements(__requires__), Environment()
File "/usr/lib/python2.6/site-packages/pkg_resources.py", line 552, in resolve
raise DistributionNotFound(req)
pkg_resources.DistributionNotFound: Djblets>=0.6.0
Argh, so it turns out that ReviewBoard 1.0.8 has a requirement on DJblets 0.6.0 or higher, but this wasn't listed in the release notes. Things worked fine in my testing because I happened to have DJblets 0.6.3 installed on my machine for testing ReviewBoard 1.5.0. On the other hand, this was in updates-testing for two and a half months without any negative karma. Anyway, I'm reopening this. I'm building ReviewBoard 1.0.9 and DJblets 0.6.3 for Fedora 13 now, and I'll make sure that they share a single update request so they'll be pushed together. ReviewBoard-1.0.9-6.fc13,python-djblets-0.6.3-5.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/ReviewBoard-1.0.9-6.fc13,python-djblets-0.6.3-5.fc13 ReviewBoard-1.0.9-6.fc13, python-djblets-0.6.3-5.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 418623 [details] Proposed fix Description of problem: Traceback (most recent call last): File "/usr/lib/python2.6/site-packages/reviewboard/cmdline/rbsite.py", line 770, in next_page func() File "/usr/lib/python2.6/site-packages/reviewboard/cmdline/rbsite.py", line 944, in call_func func() File "/usr/lib/python2.6/site-packages/reviewboard/cmdline/rbsite.py", line 313, in sync_database self.run_manage_command("syncdb", ["--noinput"]) File "/usr/lib/python2.6/site-packages/reviewboard/cmdline/rbsite.py", line 352, in run_manage_command execute_manager(reviewboard.settings, [__file__, cmd] + params) File "/usr/lib/python2.6/site-packages/django/core/management/__init__.py", line 438, in execute_manager utility.execute() File "/usr/lib/python2.6/site-packages/django/core/management/__init__.py", line 379, in execute self.fetch_command(subcommand).run_from_argv(self.argv) File "/usr/lib/python2.6/site-packages/django/core/management/base.py", line 191, in run_from_argv self.execute(*args, **options.__dict__) File "/usr/lib/python2.6/site-packages/django/core/management/base.py", line 218, in execute output = self.handle(*args, **options) File "/usr/lib/python2.6/site-packages/django/core/management/base.py", line 347, in handle return self.handle_noargs(**options) File "/usr/lib/python2.6/site-packages/django/core/management/commands/syncdb.py", line 103, in handle_noargs emit_post_sync_signal(created_models, verbosity, interactive, db) File "/usr/lib/python2.6/site-packages/django/core/management/sql.py", line 185, in emit_post_sync_signal interactive=interactive, db=db) File "/usr/lib/python2.6/site-packages/django/dispatch/dispatcher.py", line 162, in send response = receiver(signal=self, sender=sender, **named) File "/usr/lib/python2.6/site-packages/reviewboard/admin/management/sites.py", line 21, in init_siteconfig create_default_site(app, created_models, verbosity) TypeError: create_default_site() takes exactly 4 arguments (3 given) Version-Release number of selected component (if applicable): ReviewBoard-1.0.5.1-2.fc13.noarch Additional info: Proposed patch attached.