Bug 600639

Summary:	fails lvm-snapshot schroot (snapshot-name)
Product:	[Fedora] Fedora	Reporter:	Oron Peled <oron>
Component:	schroot	Assignee:	Zach Carter <os>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	13	CC:	os, rleigh
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	schroot-1.2.3-5.fc12	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-06-28 17:11:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Oron Peled 2010-06-05 11:03:31 UTC

Description of problem:
Fails to create a schroot with type=lvm-snapshot because the default
logical name of the created snapshot is illegal.

Version-Release number of selected component (if applicable):
schroot-1.2.3-8.fc13.i686 + applied workaround from bug #600636

Steps to Reproduce:
1. Use the same schroot definition as in bug #600636
2. Try to enter this schroot:
    [oron@radon ~]$ schroot -c test-f13
    E: test-f13-2010-06-05T09:55:21Z-532: Failed to lock chroot: /dev/vg_radon/lv_f-13: Failed to lock device: Failed to lock device

Additional info:
1. The problem is the ':' is an illegal character in logical volume name.
   This can be easily verified by trying to create one manually (as root):
   lvcreate -n "foo:bar" vol_group_name
2. The name is created in session::run_impl() (line 547)
3. The code can generate UUID based name instead, which solves the problem:
   - Simply adding "BuildRequires: libuuid-devel" to schroot.spec is good.
     (when configure detects libuuid headers, it uses this code)
   - Debian lenny also use it as can be seen from the lvm-snapshot names
     generated.
4. I still think the non-libuuid code is an upstream bug.

Comment 1 Zach Carter 2010-06-06 15:01:48 UTC

Thanks Oron.

This bug was already reported upstream on 5/30 as debian bug #583504.

The BuildRequires: libuuid-devel workaround is already in place in the rawhide version of schroot.  I'll try to get an update into F13 and F12 soon.

Comment 2 Roger Leigh 2010-06-07 22:30:51 UTC

While having a libuuid-devel BR will fix this nicely, I've also fixed the underlying issue in upstream git and this should be in a new release within the week once I've done some further testing.  I've basically switched from using ISO-8601-formatted dates to UNIX time [time(2)] output for chroot session names in the absence of UUID support.  This has the same time resolution, but won't use the illegal characters seen in the ISO-8601 date.


Regards,
Roger

Comment 3 Fedora Update System 2010-06-08 19:13:01 UTC

schroot-1.2.3-9.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/schroot-1.2.3-9.fc13

Comment 4 Zach Carter 2010-06-09 16:37:43 UTC

*** Bug 588207 has been marked as a duplicate of this bug. ***

Comment 5 Fedora Update System 2010-06-09 19:59:13 UTC

schroot-1.2.3-5.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/schroot-1.2.3-5.fc12

Comment 6 Fedora Update System 2010-06-10 19:11:44 UTC

schroot-1.2.3-5.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update schroot'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/schroot-1.2.3-5.fc12

Comment 7 Fedora Update System 2010-06-10 19:12:09 UTC

schroot-1.2.3-9.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update schroot'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/schroot-1.2.3-9.fc13

Comment 8 Fedora Update System 2010-06-28 17:11:38 UTC

schroot-1.2.3-9.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2010-06-28 17:19:42 UTC

schroot-1.2.3-5.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.