Bug 601771
Summary: | Review Request: iwl6050-firmware - Firmware for Intel(R) Wireless WiFi Link 6050 Series Adapters | |||
---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | John W. Linville <linville> | |
Component: | Package Review | Assignee: | Bill Nottingham <notting> | |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
Severity: | medium | Docs Contact: | ||
Priority: | medium | |||
Version: | rawhide | CC: | fedora-package-review, notting, rvokal | |
Target Milestone: | --- | Flags: | notting:
fedora-review+
kevin: fedora-cvs+ |
|
Target Release: | --- | |||
Hardware: | All | |||
OS: | Linux | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | Bug Fix | ||
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 603859 (view as bug list) | Environment: | ||
Last Closed: | 2010-06-14 17:37:24 UTC | Type: | --- | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 603859, 603860 |
Description
John W. Linville
2010-06-08 15:15:05 UTC
Well, it appears to just be s/6000/6050/ on the iwl6000-firmware package. But still, for completeness sake... MUST items: - Package meets naming and packaging guidelines - ok - Spec file matches base package name. - ok - Spec has consistant macro usage. - ok - Meets Packaging Guidelines. - ok - License - standard firmware license - License field in spec matches - "Redistributable, no modification permitted" - License file included in package - ok - Spec in American English - ok - Spec is legible. - ok - Sources match upstream md5sum: 1cbca537d7c9af2c8d1f40b00cb430055b6f06de4b6d29e2a318bb0eae3352ff iwlwifi-6050-ucode-9.201.4.1.tgz OK - Package needs ExcludeArch - N/A - BuildRequires correct - OK - Spec handles locales/find_lang - N/A - Package is relocatable and has a reason to be. - N/A - Package has %defattr and permissions on files is good. - OK - Package has a correct %clean section. - OK - Package has correct buildroot - OK %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Package is code or permissible content. - oK - Doc subpackage needed/used. - N/A - Packages %doc files don't affect runtime. - N/A - Package compiles and builds on at least one arch. - OK (tested x86_64) - Package has no duplicate files in %files. - OK - Package doesn't own any directories other packages own. - OK - Package owns all the directories it creates. -OK - No rpmlint output. - *** iwl6050-firmware.noarch: W: spurious-executable-perm /usr/share/doc/iwl6050-firmware-9.201.4.1/README iwl6050-firmware.noarch: W: spurious-executable-perm /usr/share/doc/iwl6050-firmware-9.201.4.1/LICENSE That can be fixed, but it's not critical. - final provides and requires are sane: - OK SHOULD Items: - Should build in mock. - didn't try - Should build on all supported archs - didn't try - Should function as described. - OK (tested with 6250 part) - Should have dist tag - OK - Should package latest version - OK APPROVED. Feel free to fix the docs perms. New Package CVS Request ======================= Package Name: iwl6050-firmware Short Description: Firmware for Intel(R) Wireless WiFi Link 6050 Series Adapters Owners: linville Branches: F-12 F-13 InitialCC: linville CVS done (by process-cvs-requests.py). |