Bug 601771 - Review Request: iwl6050-firmware - Firmware for Intel(R) Wireless WiFi Link 6050 Series Adapters
Summary: Review Request: iwl6050-firmware - Firmware for Intel(R) Wireless WiFi Link 6...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Bill Nottingham
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 603859 603860
TreeView+ depends on / blocked
 
Reported: 2010-06-08 15:15 UTC by John W. Linville
Modified: 2014-03-17 03:23 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 603859 (view as bug list)
Environment:
Last Closed: 2010-06-14 17:37:24 UTC
Type: ---
Embargoed:
notting: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description John W. Linville 2010-06-08 15:15:05 UTC
Spec URL: http://linville.fedorapeople.org/iwl6050-firmware.spec
SRPM URL: http://linville.fedorapeople.org/iwl6050-firmware-9.201.4.1-1.fc14.src.rpm
Description:
This package contains the firmware required by the iwlagn driver
for Linux to support the iwl6050 hardware.  Usage of the firmware
is subject to the terms and conditions contained inside the provided
LICENSE file. Please read it carefully.

Comment 1 Bill Nottingham 2010-06-08 17:06:33 UTC
Well, it appears to just be s/6000/6050/ on the iwl6000-firmware package. But still, for completeness sake...

MUST items:
- Package meets naming and packaging guidelines - ok
- Spec file matches base package name. - ok
- Spec has consistant macro usage.  - ok
- Meets Packaging Guidelines. - ok
- License  - standard firmware license
- License field in spec matches - "Redistributable, no modification permitted" 
- License file included in package - ok
- Spec in American English - ok 
- Spec is legible. - ok
- Sources match upstream md5sum:

1cbca537d7c9af2c8d1f40b00cb430055b6f06de4b6d29e2a318bb0eae3352ff  iwlwifi-6050-ucode-9.201.4.1.tgz

OK

- Package needs ExcludeArch - N/A
- BuildRequires correct - OK
- Spec handles locales/find_lang - N/A
- Package is relocatable and has a reason to be. - N/A
- Package has %defattr and permissions on files is good. - OK
- Package has a correct %clean section. - OK
- Package has correct buildroot - OK
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- Package is code or permissible content. - oK
- Doc subpackage needed/used. - N/A
- Packages %doc files don't affect runtime.  - N/A

- Package compiles and builds on at least one arch. - OK (tested x86_64)
- Package has no duplicate files in %files.  - OK
- Package doesn't own any directories other packages own. - OK
- Package owns all the directories it creates.  -OK
- No rpmlint output. - ***

iwl6050-firmware.noarch: W: spurious-executable-perm /usr/share/doc/iwl6050-firmware-9.201.4.1/README
iwl6050-firmware.noarch: W: spurious-executable-perm /usr/share/doc/iwl6050-firmware-9.201.4.1/LICENSE

That can be fixed, but it's not critical.

- final provides and requires are sane: - OK

SHOULD Items:

- Should build in mock. - didn't try
- Should build on all supported archs - didn't try
- Should function as described. - OK (tested with 6250 part)
- Should have dist tag - OK
- Should package latest version - OK

APPROVED. Feel free to fix the docs perms.

Comment 2 John W. Linville 2010-06-08 17:25:10 UTC
New Package CVS Request
=======================
Package Name: iwl6050-firmware
Short Description: Firmware for Intel(R) Wireless WiFi Link 6050 Series Adapters
Owners: linville
Branches: F-12 F-13
InitialCC: linville

Comment 3 Kevin Fenzi 2010-06-11 04:54:52 UTC
CVS done (by process-cvs-requests.py).


Note You need to log in before you can comment on or make changes to this bug.