Bug 602147

Summary: 'GitNode' object has no attribute 'log'
Product: [Fedora] Fedora EPEL Reporter: Ferry Huberts <mailings>
Component: trac-git-pluginAssignee: David Cantrell <dcantrell>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: el5CC: dcantrell
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-07-02 08:44:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch none

Description Ferry Huberts 2010-06-09 09:23:19 UTC
Created attachment 422483 [details]
patch

Description of problem:
Sometimes an exception is thrown:
  'GitNode' object has no attribute 'log'

Version-Release number of selected component (if applicable):
trac-git-plugin 0.0.1-5.20090628svn3369.el5

How reproducible:
on some repositories always, on others never.

Steps to Reproduce:
1. browse source via trac on an affected repository
2.
3.
  
Actual results:
exception trace

Expected results:
normal source browsing

Additional info:
The exception is thrown because self.log is accessed in a GitNode object while that object has no log.

As it's a debug log only, we can easily get rid of it.
I wrote a patch to do just that

Comment 1 Ferry Huberts 2010-06-09 09:35:15 UTC
from what I can see now it is reproducible on repositories that use submodules

Comment 2 Ferry Huberts 2011-07-02 08:44:59 UTC

*** This bug has been marked as a duplicate of bug 580702 ***