Description of problem:
Currently when accessing the source browser when using the git plugin on a repository that uses submodules this causes the error "internal error (got unexpected object kind 'commit')".
The problem is easily fixed by simply ignoring the commit objects. The attached patch trivially fixes this.
Version-Release number of selected component (if applicable):
Any currently packaged version, as the patch is not in the upstream repository. That includes all Fedora and EPEL versions.
Steps to Reproduce:
1. Create Trac instance for git repository with submodule
2. Got to "Browse Source"
internal error (got unexpected object kind 'commit')
Should simply ignore the submodule commit.
The problem has been reported upstream at http://trac-hacks.org/ticket/3104 but there is not much activity and hence the patch should be applied to the package until this is fixed upstream to allow git repositories with submodules to work.
Created attachment 405390 [details]
Patch to fix Trac git plugin when using submodules
Just realized that the patch is for a newer version of the plugin that I build (0.11 branch). So this should apply to the Fedora packages. For EL-5 this might need modification as the patch is ~130 lines off (http://trac-hacks.org/browser/gitplugin/0.10/gitplugin/git_fs.py#L177). Still trivial...
Jesse, are you considering to apply this patch?
oh I probably should.
trac-git-plugin-0.11.0.2-7.20090511svn5396.fc14 has been submitted as an update for Fedora 14.
trac-git-plugin-0.0.1-6.20090628svn3369.el5 has been submitted as an update for Fedora EPEL 5.
* should fix your issue,
* was pushed to the Fedora 14 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing trac-git-plugin-0.11.0.2-7.20090511svn5396.fc14'
as soon as you are able to.
Please go to the following url:
then log in and leave karma (feedback).
trac-git-plugin-0.11.0.2-7.20090511svn5396.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
trac-git-plugin-0.0.1-6.20090628svn3369.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
*** Bug 602147 has been marked as a duplicate of this bug. ***
Tim, can you make sure that the git trac plugin on EPEL 6 works correctly with repos with submodules (I have no RHEL6 installs)
I currently have no RHEL 6 install either. I won't be before August that I get to do this.