Bug 602505

Summary:	coverity: ldbm_back_upgradedb: upgradedb_copy_logfiles does cnt++ instead of (*cnt)++
Product:	[Retired] 389	Reporter:	Noriko Hosoi <nhosoi>
Component:	Database - General	Assignee:	Noriko Hosoi <nhosoi>
Status:	CLOSED DUPLICATE	QA Contact:	Chandrasekar Kannan <ckannan>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	1.2.6	CC:	benl, jgalipea, rmeggins
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11772&streamDefectId=11958&defectInstanceId=13816&fileInstanceId=49336
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-08-05 21:19:31 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	434915, 576869

Description Noriko Hosoi 2010-06-10 02:14:16 UTC

Description of problem:
11772 ARRAY_VS_SINGLETON Triaged Bug Minor Fix Required ldbm_back_upgradedb()
File: ds/ldap/servers/slapd/back-ldbm/ldif2ldbm.c

Status:  	New  	→  	Triaged
Classification: 	Unclassified 	→ 	Bug
Action: 	Undecided 	→ 	Fix Required
Severity: 	Unspecified 	→ 	Minor

Comment:
upgradedb_copy_logfiles does cnt++ instead of (*cnt)++ but cnt is not used in that function, nor is the value of cnt used anywhere else. I think the proper fix is to just get rid of the cnt parameter to upgradedb_copy_logfiles.

Comment 2 Noriko Hosoi 2010-08-05 21:19:31 UTC


*** This bug has been marked as a duplicate of bug 609590 ***