Bug 603634

This package should be renamed to python-robofab, the same reason with #603640

Following python naming guidelines now
Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/python-robofab.spec
SRPM URL:
http://paragn.fedorapeople.org/fedora-work/SRPMS/python-robofab-1.2.0-1.svn200.fc13.src.rpm

python-robofab.noarch: W: no-documentation

PASS

Thanks for the review!

New Package CVS Request
=======================
Package Name: python-robofab
Short Description: Reads and writes UFO font files 
Owners: pnemade
Branches: F-13 EL-6
InitialCC: i18n-team fonts-sig

Some suggestions:
1.Group:          Development/Languages->Group:          Development/Libraries

Development/Languages is for python runtime only.
2.
It'll be better add %check to the spec after %install, then del robofab/test

%check
PYTHONPATH=%{buildroot}%{python_sitelib} python RoboFab/robofab/test/runAll.py

3. Are all files under Scripts useless for this package?

(In reply to comment #5)
> Some suggestions:
> 1.Group:          Development/Languages->Group:          Development/Libraries
> 
> Development/Languages is for python runtime only.

May I know where its documented? I think we can find many python-* packages in Fedora using Development/Languages

> 2.
> It'll be better add %check to the spec after %install, then del robofab/test
> 
> %check
> PYTHONPATH=%{buildroot}%{python_sitelib} python RoboFab/robofab/test/runAll.py
> 

Is this MUST by guidelines.

> 3. Are all files under Scripts useless for this package?    

I see they are broken.
+ python robofab/test/runAll.py
Traceback (most recent call last):
  File "robofab/test/runAll.py", line 5, in <module>
    import robofab.test
ImportError: No module named test

(In reply to comment #6)
> (In reply to comment #5)
> > Some suggestions:
> > 1.Group:          Development/Languages->Group:          Development/Libraries
> > 
> > Development/Languages is for python runtime only.
> May I know where its documented? I think we can find many python-* packages in
> Fedora using Development/Languages
Long ago, I see rpm group definitions from an opensuse document, I can confirm Development/Languages is for python/perl/ruby/lisp runtime only and not appropriate for python modules. But I'm not sure if Development/Libraries is right for python modules, but a lot of python modules in fedora already use Development/Libraries as their group name.
See http://en.opensuse.org/Packaging/SUSE_Package_Conventions/RPM_Groups#2.2._Development

> > 2.
> > It'll be better add %check to the spec after %install, then del robofab/test
> > 
> > %check
> > PYTHONPATH=%{buildroot}%{python_sitelib} python RoboFab/robofab/test/runAll.py
> > 
> Is this MUST by guidelines.
%check section is not mandatory in fedora packaging guideline yet it depends on packages/maintainers, but it'll be better to add %check in spec file if possible.
Maybe the test can pass if we change the command to:

PYTHONPATH=RoboFab python RoboFab/robofab/test/runAll.py

CVS done (by process-cvs-requests.py).

I have informed upstream about testcases not working and they are working on it. For now I will build this and once upstream resolves test case issues will update it in next build.

python-robofab-1.2.0-1.svn226.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/python-robofab-1.2.0-1.svn226.fc13

python-robofab-1.2.0-1.svn226.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-robofab'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/python-robofab-1.2.0-1.svn226.fc13

This update is already in F-13 stable, bodhi seems to forgot to close this.

-> Doing so now.

Package Change Request
======================
Package Name: python-robofab
New Branches: epel7
Owners: pnemade

Git done (by process-git-requests).