Bug 619970

Summary:	ocfs2-tools needs to be rebuilt against python 2.7 in F14 and devel
Product:	[Fedora] Fedora	Reporter:	Dave Malcolm <dmalcolm>
Component:	ocfs2-tools	Assignee:	Mark Fasheh <mark>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	14	CC:	a.badger, fdinitto, mark, sunil.mushran, tomspur
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-12-03 08:28:24 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	619913

Description Dave Malcolm 2010-07-31 01:44:56 UTC

The package needs to be rebuilt against python 2.7 in both F14 and devel.

Automated rebuild failed with:
  mount.ocfs2.c:264:2: error: variable-sized object may not be initialized
http://koji.fedoraproject.org/koji/getfile?taskID=2344885&name=build.log

I'm guessing that this is a GCC 4.4 -> 4.5 change.

Information on the new "dist-git" system can be seen here:
  http://fedoraproject.org/wiki/Using_Fedora_GIT

Information on common difficulties with Python 2.7 rebuilds can be seen here:
  https://fedoraproject.org/wiki/Features/Python_2.7

Once it's been successfully rebuilt for F14, an update needs to be filed to get the rebuild into F14:
  https://admin.fedoraproject.org/updates/new/

Please add this bug to the update, to make it easy to track what's been done, and what's left to do.

Thanks!

Comment 1 Sunil Mushran 2010-08-02 23:15:27 UTC

264         char stackstr[strlen(OCFS2_CLUSTER_STACK_ARG) + OCFS2_STACK_LABEL_LEN + 1] = "";

Not sure I understand the compile error. Trying to get hold of a box with gcc 4.5 to make sense of this.

Comment 2 Sunil Mushran 2010-08-03 00:07:22 UTC

http://oss.oracle.com/git/?p=ocfs2-tools.git;a=commitdiff;h=862001a972b495a79cafa98c8b7559b603ac5bf8

Which version of ocfs2-tools are you building?

Comment 3 Fedora Update System 2010-08-03 12:49:51 UTC

ocfs2-tools-1.4.3-8.fc14 has been submitted as an update for Fedora 14.
http://admin.fedoraproject.org/updates/ocfs2-tools-1.4.3-8.fc14

Comment 4 Toshio Ernie Kuratomi 2010-08-03 12:51:36 UTC

This is fixed with a small patch.  Please see about getting it or another patch that accomplishes the same thing to upstream.  (My C is a little rusty and I'm not sure if strcpy would be better to use to initialize that value).

Comment 5 Toshio Ernie Kuratomi 2010-08-03 12:54:49 UTC

*** Bug 620195 has been marked as a duplicate of this bug. ***

Comment 6 Fedora Update System 2010-08-05 14:26:08 UTC

ocfs2-tools-1.4.3-8.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.