Bug 626699

I'd be happy to review this one. Is the Whiteboard: NotReady only because all of the deps were not yet built in Fedora?

> Patch1:                 libmcrypto-0001-Fix-building-with-gnutls-and-new-GCC.patch
> Patch2:                 libmcrypto-0002-Compile-OpenSSL-module-with-newest-GCC.patch
> Patch3:                 libmcrypto-0003-Compile-with-OpenSSL-1.0.patch

These patches (at least 1 and 3, I don't really understand how 2 works) look like nice upstreamable fixes. If upstream uses a public bug tracker it would be nice to add a comment with a link to the ticket which tracks upstream inclusion for these patches.

(In reply to comment #1)
> Is the Whiteboard: NotReady only because all
> of the deps were not yet built in Fedora?

Yes, exactly. I'll remove this keyword as soon as libmnetutill will hit Rawhide.

> > Patch1:                 libmcrypto-0001-Fix-building-with-gnutls-and-new-GCC.patch
> > Patch2:                 libmcrypto-0002-Compile-OpenSSL-module-with-newest-GCC.patch
> > Patch3:                 libmcrypto-0003-Compile-with-OpenSSL-1.0.patch
> 
> These patches (at least 1 and 3, I don't really understand how 2 works) look
> like nice upstreamable fixes. If upstream uses a public bug tracker it would be
> nice to add a comment with a link to the ticket which tracks upstream inclusion
> for these patches.

Unfortunately I didn't try to contact upstream yet, but I'll do.

Looks like libmnetutil-0.8.0-0.2.20100629svn3775.fc15 is in rawhide, so I'm taking it for review and also took the liberty of removing Whiteboard: NotReady.

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2527448

Fedora review libmcrypto-0.8.0-0.1.20100629svn3775.fc12.src.rpm 2010-10-11

+ OK
! needs attention

rpmlint output:
$ rpmlint libmcrypto \
          libmcrypto-devel \
          libmcrypto-0.8.0-0.1.20100629svn3775.fc15.src.rpm \
          libmcrypto-debuginfo-0.8.0-0.1.20100629svn3775.fc15.i686.rpm
libmcrypto.i686: W: unused-direct-shlib-dependency /usr/lib/libmcrypto.so.0.0.0 /lib/libdl.so.2
libmcrypto.i686: W: unused-direct-shlib-dependency /usr/lib/libmcrypto.so.0.0.0 /lib/libz.so.1
libmcrypto.i686: W: unused-direct-shlib-dependency /usr/lib/libmcrypto.so.0.0.0 /lib/libm.so.6
libmcrypto.i686: W: shared-lib-calls-exit /usr/lib/libmcrypto.so.0.0.0 exit
libmcrypto-devel.i686: W: no-documentation
libmcrypto.src: W: invalid-url Source0: libmcrypto-0.8.0.tar.bz2
4 packages and 0 specfiles checked; 0 errors, 6 warnings.

+ Rpmlint warnings are mostly harmless and can be ignored.
  shared-lib-calls-exit is something to take up with upstream as it might
  result in application crashes if a library unexpectedly calls exit().

+ The package is named according to the Package Naming Guidelines.
+ Spec file name matches the base package name
+ The package is licensed with a Fedora approved license and meets the Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The package contains license file (COPYING.LIB)
+ Spec file is written in American English
+ Spec file is legible
+ Following instructions in the spec file to check out sources
  from upstream svn repo produce matching tarball.
  cf48f3a539901d86a91b167cf8cdcdfc  libmcrypto-0.8.0.tar.bz2

+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file MUST handle locales properly
+ ldconfig is properly called in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set and %files has %defattr
+ Consistent use of macros
+ The package must contain code, or permissable content.
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc don't affect the package
+ Header files are in -devel
n/a Static libraries should be in -static
+ Library files that end in .so are in -devel package
+ -devel requires the fully versioned base
+ Package doesn't contain any libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8

Looks good.

APPROVED

New Package SCM Request
=======================
Package Name: libmcrypto
Short Description: A C++ library providing various cryptography related utilities
Owners: peter
Branches: f12 f13 f14 el6
InitialCC:

Git done (by process-git-requests).

libmcrypto is imported and built for rawhide. Closing the ticket to make it easier to check bugzilla dependencies between review requests.

libmcrypto-0.8.0-0.1.20100629svn3775.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/libmcrypto-0.8.0-0.1.20100629svn3775.fc13

libmcrypto-0.8.0-0.1.20100629svn3775.fc12 has been submitted as an update for Fedora 12.
https://admin.fedoraproject.org/updates/libmcrypto-0.8.0-0.1.20100629svn3775.fc12

libmcrypto-0.8.0-0.1.20100629svn3775.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/libmcrypto-0.8.0-0.1.20100629svn3775.fc14

libmcrypto-0.8.0-0.1.20100629svn3775.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

libmcrypto-0.8.0-0.1.20100629svn3775.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

libmcrypto-0.8.0-0.1.20100629svn3775.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.