Bug 626701 - Review Request: libmikey - A C++ library implementing the Multimedia Internet KEYing protocol
Summary: Review Request: libmikey - A C++ library implementing the Multimedia Internet...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Kalev Lember
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 626446 626458 626699
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-08-24 07:31 UTC by Peter Lemenkov
Modified: 2010-11-08 22:43 UTC (History)
3 users (show)

Fixed In Version: libmikey-0.8.0-0.2.20100127svn3750.fc13
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-11-08 22:34:54 UTC
Type: ---
Embargoed:
kalevlember: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Peter Lemenkov 2010-08-24 07:31:52 UTC
Spec URL: http://peter.fedorapeople.org/libmikey.spec
SRPM URL: http://peter.fedorapeople.org/libmikey-0.8.0-0.1.20100127svn3750.fc12.src.rpm
Description: libmikey is a C++ library that implements the Multimedia Internet KEYing. This protocol aims to provide a key exchange for secure multimedia streaming. It is usually embedded in SIP or RTSP session setup.

No koji build for now since it depends on a libraries not yet added to Fedora.

It's another one requirement for minisip.

Comment 1 Kalev Lember 2010-10-13 16:40:24 UTC
All deps of libmikey appear to be in rawhide now.

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2532858

failed with the following error:

mikey/MikeyCsIdMap.cxx: In constructor 'MikeyCsIdMapSrtp::MikeyCsIdMapSrtp()':
mikey/MikeyCsIdMap.cxx:39:44: error: cannot call constructor 'std::vector<MikeySrtpCs*>::vector' directly
mikey/MikeyCsIdMap.cxx:39:44: error:   for a function-style cast, remove the redundant '::vector'
mikey/MikeyCsIdMap.cxx: In constructor 'MikeyCsIdMapIPSEC4::MikeyCsIdMapIPSEC4()':
mikey/MikeyCsIdMap.cxx:44:42: error: cannot call constructor 'std::list<MikeyIPSEC4Cs*>::list' directly
mikey/MikeyCsIdMap.cxx:44:42: error:   for a function-style cast, remove the redundant '::list'

Comment 3 Kalev Lember 2010-10-29 08:25:00 UTC
Taking for review.

Comment 4 Kalev Lember 2010-10-29 09:31:37 UTC
Fedora review libmikey-0.8.0-0.2.20100127svn3750.fc12.src.rpm 2010-10-29

+ OK
! needs attention

rpmlint output:
$ rpmlint libmikey \
          libmikey-devel \
          libmikey-0.8.0-0.2.20100127svn3750.fc15.src.rpm \
          libmikey-debuginfo-0.8.0-0.2.20100127svn3750.fc15.i686.rpm
libmikey.i686: W: unused-direct-shlib-dependency /usr/lib/libmikey.so.0.0.0 /usr/lib/libmnetutil.so.0
libmikey.i686: W: unused-direct-shlib-dependency /usr/lib/libmikey.so.0.0.0 /lib/libm.so.6
libmikey-devel.i686: W: no-documentation
libmikey.src: W: invalid-url Source0: libmikey-0.8.0.tar.bz2
4 packages and 0 specfiles checked; 0 errors, 4 warnings.

+ Rpmlint warnings are mostly harmless. 
  If you want to, you can try fixing libmnetutil.so.0 dependency,
  but this is certainly not a review blocker.

+ The package is named according to the Package Naming Guidelines.
+ Spec file name matches the base package name
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The package contains license file (COPYING.LIB)
+ Spec file is written in American English
+ Spec file is legible
+ Following instructions in the spec file to check out sources
  from upstream svn repo produce matching tarball.
  b22c89a5e1d5745149a23e0e1527ceee  ../SOURCES/libmikey-0.8.0.tar.bz2

+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file MUST handle locales properly
+ ldconfig is properly called in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set and %files has %defattr
+ Consistent use of macros
+ The package must contain code, or permissable content.
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc don't affect the package
+ Header files are in -devel
n/a Static libraries should be in -static
+ Library files that end in .so are in -devel package
+ -devel requires the fully versioned base
+ Package doesn't contain any libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8

Looks good. Please don't forget to send the build fix patch upstream.

APPROVED

Comment 5 Peter Lemenkov 2010-10-29 10:38:57 UTC
Thanks, Kalev!

Comment 6 Peter Lemenkov 2010-10-29 10:41:59 UTC
New Package SCM Request
=======================
Package Name: libmikey
Short Description: A C++ library implementing the Multimedia Internet KEYing protocol
Owners: peter
Branches: f12 f13 f14 el6
InitialCC:

Comment 7 Kevin Fenzi 2010-10-30 23:20:24 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2010-10-31 05:40:32 UTC
libmikey-0.8.0-0.2.20100127svn3750.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/libmikey-0.8.0-0.2.20100127svn3750.fc13

Comment 9 Fedora Update System 2010-10-31 05:40:38 UTC
libmikey-0.8.0-0.2.20100127svn3750.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/libmikey-0.8.0-0.2.20100127svn3750.fc14

Comment 10 Fedora Update System 2010-10-31 05:40:45 UTC
libmikey-0.8.0-0.2.20100127svn3750.fc12 has been submitted as an update for Fedora 12.
https://admin.fedoraproject.org/updates/libmikey-0.8.0-0.2.20100127svn3750.fc12

Comment 11 Fedora Update System 2010-10-31 21:31:46 UTC
libmikey-0.8.0-0.2.20100127svn3750.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update libmikey'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/libmikey-0.8.0-0.2.20100127svn3750.fc13

Comment 12 Fedora Update System 2010-11-08 22:34:49 UTC
libmikey-0.8.0-0.2.20100127svn3750.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2010-11-08 22:41:08 UTC
libmikey-0.8.0-0.2.20100127svn3750.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2010-11-08 22:43:29 UTC
libmikey-0.8.0-0.2.20100127svn3750.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.