Bug 637448
| Summary: | Review Request: rubygem-glib2 - Ruby binding of GLib-2.x | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mamoru TASAKA <mtasaka> |
| Component: | Package Review | Assignee: | Michal Fojtik <mfojtik> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mfojtik, notting |
| Target Milestone: | --- | Flags: | mfojtik:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-10-23 16:59:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 637904, 637939, 637985, 639098, 639636, 639638 | ||
|
Description
Mamoru TASAKA
2010-09-25 21:57:45 UTC
http://mtasaka.fedorapeople.org/Review_request/rubygem-glib/rubygem-glib2.spec http://mtasaka.fedorapeople.org/Review_request/rubygem-glib/rubygem-glib2-0.90.2-2.fc.src.rpm * Mon Sep 27 2010 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 0.90.2-2 - 0.90.2 released, release bump http://mtasaka.fedorapeople.org/Review_request/rubygem-glib2/rubygem-glib2.spec http://mtasaka.fedorapeople.org/Review_request/rubygem-glib2/rubygem-glib2-0.90.2-3.fc.src.rpm * Tue Sep 28 2010 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 0.90.2-3 - Modify Obsoletes http://mtasaka.fedorapeople.org/Review_request/rubygem-glib2/rubygem-glib2.spec http://mtasaka.fedorapeople.org/Review_request/rubygem-glib2/rubygem-glib2-0.90.2-4.fc.src.rpm * Tue Sep 28 2010 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 0.90.2-4 - Modify Obsoletes - Fix %%description http://mtasaka.fedorapeople.org/Review_request/rubygem-glib2/rubygem-glib2.spec http://mtasaka.fedorapeople.org/Review_request/rubygem-glib2/rubygem-glib2-0.90.2-5.fc.src.rpm * Fri Oct 1 2010 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 0.90.2-5 - Use formally released gem file http://mtasaka.fedorapeople.org/Review_request/rubygem-glib2/rubygem-glib2.spec http://mtasaka.fedorapeople.org/Review_request/rubygem-glib2/rubygem-glib2-0.90.2-6.fc.src.rpm * Fri Oct 1 2010 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 0.90.2-6 - Fix up summary REVIEW:
[OK] Packages that contain Ruby Gems must be called rubygem-%{gemname} where gemname is the name from the Gem's specification.
[OK] The Source of the package must be the full URL to the released Gem archive; the version of the package must be the Gem's version
[OK] The package must have a Requires and a BuildRequires on rubygems
[OK] The package must provide rubygem(%{gemname}) where gemname is the name from the Gem's specification.
[OK] For every dependency on a Gem named gemdep, the package must contain a Requires on rubygem(%{gemdep}) with the same version constraints as the Gem
[OK] The Gem must be installed into %{gemdir} defined as
%global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null)
The install should be performed with the command
gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0}
The package must own the following files and directories:
%{gemdir}/gems/%{gemname}-%{version}/
%{gemdir}/cache/%{gemname}-%{version}.gem
%{gemdir}/specifications/%{gemname}-%{version}.gemspec
[OK] Architecture-specific content must not be installed into %{gemdir}
[OK] %prep stage must contain %setup -q -c -T to create the directory where C libraries are compiled.
Package looks good, builds without errors/warning under Koji, rpmlint is quite.
Setting REVIEW+
Thank you! New Package SCM Request ======================= Package Name: rubygem-glib2 Short Description: Ruby bindings of GLib-2.x Owners: mtasaka Branches: f12 f13 f14 Git done (by process-git-requests). Built for f13 f14 (will not build for f12), submitted push requests on bodhi. Now in testing. Can be closed. |