Bug 637985
| Summary: | Review Request: rubygem-pango - Ruby binding of pango-1.x | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mamoru TASAKA <mtasaka> |
| Component: | Package Review | Assignee: | Michal Fojtik <mfojtik> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mfojtik, notting |
| Target Milestone: | --- | Flags: | mfojtik:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-10-24 19:07:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 635302, 637448 | ||
| Bug Blocks: | 639098 | ||
|
Description
Mamoru TASAKA
2010-09-27 22:08:32 UTC
http://mtasaka.fedorapeople.org/Review_request/rubygem-pango/rubygem-pango.spec http://mtasaka.fedorapeople.org/Review_request/rubygem-pango/rubygem-pango-0.90.2-4.fc.src.rpm * Fri Oct 1 2010 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 0.90.2-4 - Use formally released gem file http://mtasaka.fedorapeople.org/Review_request/rubygem-pango/rubygem-pango.spec http://mtasaka.fedorapeople.org/Review_request/rubygem-pango/rubygem-pango-0.90.2-5.fc.src.rpm * Fri Oct 1 2010 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 0.90.2-5 - Fix up summary - Fix Requires for -devel subpackage Review:
[OK] First, %prep stage must contain %setup -q -c -T to create the directory where C libraries are compiled.
[OK] Then at %build stage the Ruby Gem must be installed under the directory created at %prep stage to get C libraries compiled under there.
[OK] When gem install is used to install Gem file, using -V option is recommend to check if CFLAGS is correctly honored.
[OK] Finally at %install stage the whole tree under the directory created at %prep stage should be copied (not moved) to under %{buildroot}%{gemdir}.
[OK] When all tree under the directory created at %prep stage is moved to under %{buildroot}, find_debuginfo.sh will complain that the corresponding source files are missing.
[OK] Installed C codes (usually under %{geminstdir}/etc) may be removed even if gem contents %{gemname} reports that installed C codes should be found there.
Unfortunately, I can't build this package because of missing rubygem-cairo-devel (which is already packaged and waiting in testing I suppose):
http://koji.fedoraproject.org/koji/taskinfo?taskID=2527617
Anyway, spec file looks good enough to me. REVIEW+
Thank you! New Package SCM Request ======================= Package Name: rubygem-pango Short Description: Ruby binding of pango-1.x Owners: mtasaka Branches: f13 f14 Git done (by process-git-requests). Built on F-13/14, push requested on bodhi: Closing as now available on rawhide |