Spec URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-cairo/rubygem-cairo.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rubygem-cairo/rubygem-cairo-1.10.0-1.fc.src.rpm Description: Ruby bindings for cairo. Cairo is a 2D graphics library with support for multiple output devices. Currently supported output targets include the X Window System, win32, and image buffers. Note: This package will replace currently existing ruby-cairo srpm Note: This package depends on bug 634759 and bug 635126. Mockbuild log with adding these rpms for F-14 is available on http://mtasaka.fedorapeople.org/Review_request/rubygem-cairo/MOCK-rubygem-cairo.log
Review: [OK ]Packages that contain Ruby Gems must be called rubygem-%{gemname} where gemname is the name from the Gem's specification. [OK] The Source of the package must be the full URL to the released Gem archive; the version of the package must be the Gem's version [OK] The package must have a Requires and a BuildRequires on rubygems [OK] The package must provide rubygem(%{gemname}) where gemname is the name from the Gem's specification. [OK] The %prep and %build sections of the specfile should be empty. [-] Build is used to compile binary extension, so it's OK to this rule [OK] The Gem must be installed into %{gemdir} defined as %global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null) [OK] The install should be performed with the command gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0} [OK] The package must own the following files and directories: %{gemdir}/gems/%{gemname}-%{version}/ %{gemdir}/cache/%{gemname}-%{version}.gem %{gemdir}/specifications/%{gemname}-%{version}.gemspec [OK] Architecture-specific content must not be installed into %{gemdir} [-] %{ruby_sitearch}/%{gemname}.so is fine here [OK, see above] If the Gem contains binary content (e.g., for a database driver), it must be marked as architecture specific, and all architecture specific content must be moved from the %{gemdir} to the [#ruby_sitearch %{ruby_sitearch} directory] during %install Overall it looks perfect to me, but Koji seems to fail to build this package for F13: 100% passed/builddir/build/BUILD/rubygem-cairo-1.10.0/usr/lib/ruby/gems/1.8/gems/cairo-1.10.0/test/test_context.rb:57:in `initialize': out of memory (NoMemoryError) from /builddir/build/BUILD/rubygem-cairo-1.10.0/usr/lib/ruby/gems/1.8/gems/cairo-1.10.0/test/test_context.rb:57:in `new'
! About test failure on F-13 - Ah, thank you. It is found that this error occurs when no fonts are found on system. http://mtasaka.fedorapeople.org/Review_request/rubygem-cairo/rubygem-cairo.spec http://mtasaka.fedorapeople.org/Review_request/rubygem-cairo/rubygem-cairo-1.10.0-2.fc.src.rpm * Tue Oct 5 2010 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> 1.10.0-2 - Install one font at BuildRequires for test F-14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2513677 F-13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2513680 New Package SCM Request ======================= Package Name: rubygem-cairo Short Description: Ruby bindings for cairo Owners: mtasaka Branches: f12 f13 f14
Git done (by process-git-requests).
Rebuilt for F-14/13/12, requested push request on bodhi.
Closing, thank you.