Bug 638244

Summary: Key's defined using unicode hex codes has stopped working in some/all layouts (e.g. ir and af layouts)
Product: [Fedora] Fedora Reporter: Hedayat Vatankhah <hedayatv>
Component: xkeyboard-configAssignee: Peter Hutterer <peter.hutterer>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: high    
Version: 14CC: alexxed, control-center-maint, lashar, pahan, peter.hutterer, rstrode, zkabelac
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: xorg-x11-xkb-utils-7.4-9.fc14 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-10-29 20:40:11 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 538278    
Attachments:
Description Flags
Fixes the bug
none
A patch to make many keys working again
none
A patch which will fix the hex codes in ir layout none

Description Hedayat Vatankhah 2010-09-28 15:14:28 UTC
Description of problem:
I've installed Fedora 14 Beta RC3 (from DVD), now I want to enable additional keyboard layour (ir) but it says "error activating XKB configuration".

• The result of xprop -root | grep XKB
_XKB_RULES_NAMES_BACKUP(STRING) = "evdev", "pc105+inet", "us", "", ""
_XKB_RULES_NAMES(STRING) = "evdev", "pc105+inet", "us", "", "grp:alt_shift_toggle"

 • The result of gconftool-2 -R /desktop/gnome/peripherals/keyboard/kbd
 layouts = [us,ir]
 options = [grp	grp:alt_shift_toggle,grp	grp:caps_switch]
 model = 


How reproducible:
100%

Steps to Reproduce:
1. install Fedora 14 Beta RC3
2. Try to add a new keyboard layout
  
Actual results:
Error window appears and it doesn't work

Expected results:
You should be able to switch to additional layouts.

Additional info:

Comment 1 Hedayat Vatankhah 2010-09-30 20:36:53 UTC
Apparently there is a bug in the current Iranian layout:
[hedayat@localhost xkb]$ setxkbmap ir
Error loading new keyboard description

Comment 2 Hedayat Vatankhah 2010-09-30 21:01:32 UTC
Created attachment 450888 [details]
Fixes the bug

This small patch fixes the problem. it is caused by extra semicolons.

Comment 3 Hedayat Vatankhah 2010-09-30 22:33:42 UTC
Created attachment 450902 [details]
A patch to make many keys working again

There is still a problem. Apparently, character codes in the symbols files do not work any longer. I've created a patch to make many essential keys working again (using character names instead of their code), but there are still some remaining. Also, this issue does not affect the Iranian keyboard layout only, and it'll probably affect many others too. IMHO, this bug does really need a serious consideration.

Comment 4 Fedora Update System 2010-10-02 20:30:20 UTC
xkeyboard-config-1.9-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/xkeyboard-config-1.9-2.fc14

Comment 5 Jens Petersen 2010-10-04 05:31:14 UTC
I believe this is all fixed upstream in 2.0.

Can we have 2.0 in f14?

Comment 6 Peter Hutterer 2010-10-05 01:02:53 UTC
the two patches that affected anything are in 1.9-2 now. 2.0 includes a bunch of other stuff too, at this point I'd rather not rebase. 2.0 is in rawhide though.

Comment 7 Fedora Update System 2010-10-05 01:23:53 UTC
xkeyboard-config-1.9-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/xkeyboard-config-1.9-3.fc14

Comment 8 Peter Hutterer 2010-10-05 01:35:47 UTC
at least in the german keyboard layout, xkeyboard-config-1.9-3.fc14.noarch seem to work for hex codes. This is not the case for you? If so, I need some more specific tests please, my knowledge of the iranian layout is non-existent and I can't tell what's broken.

Comment 9 Fedora Update System 2010-10-05 05:20:58 UTC
xkeyboard-config-1.9-3.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update xkeyboard-config'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/xkeyboard-config-1.9-3.fc14

Comment 10 Fedora Update System 2010-10-06 00:34:50 UTC
xkeyboard-config-1.9-6.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/xkeyboard-config-1.9-6.fc14

Comment 11 Hedayat Vatankhah 2010-10-06 05:51:28 UTC
Well, I had a look at the german layout. The german layout uses the hex codes in the form of UXXXX (e.g. U01E9), while in ir layout and many others, these codes are in the form 0x100XXXX. I replaced some 0x100XXXX codes with the equivalent UXXXX code, and it worked fine in ir layout too. I've tried some other layouts with 0x100XXXX hex codes, and they do not work fine too (e.g. try pressing "m" in tj layout. it generates an "m" istead of "ӣ" character. By replacing 0x10004e3 code with U04e3, the correct character is used).

So, it seems that all "0x100" strings should be replaced with "U" in key hex codes of all layouts (probably a sed -i "s/0x100/U/g" symbols/* except for the comments could do the job safely. But it should not corrupt comments either, so IMHO that's somewhat safe to do.)

Comment 12 Hedayat Vatankhah 2010-10-06 06:03:53 UTC
Created attachment 451810 [details]
A patch which will fix the hex codes in ir layout

Comment 13 Fedora Update System 2010-10-08 12:42:08 UTC
xkeyboard-config-1.9-6.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Hedayat Vatankhah 2010-10-08 22:39:00 UTC
IMHO, The problem mentioned in comments #11 and #12 is still there. But maybe it should be reported against another component?!

Comment 15 Hedayat Vatankhah 2010-10-10 07:45:08 UTC
Reopened since the main bug is still there: key codes defined using 0x100XXXX hex codes in *ANY* keyboard layout are broken. Either all 0x100XXXX codes should be replaced with UXXXX codes or the bug should be resolved, or Fedora 14 will be shipped with broken keyboard layouts.

Comment 16 Fedora Update System 2010-10-11 02:05:53 UTC
xorg-x11-xkb-utils-7.4-9.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/xorg-x11-xkb-utils-7.4-9.fc14

Comment 17 Peter Hutterer 2010-10-11 02:07:49 UTC
*** Bug 640915 has been marked as a duplicate of this bug. ***

Comment 18 Fedora Update System 2010-10-11 03:45:08 UTC
xorg-x11-xkb-utils-7.4-9.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update xorg-x11-xkb-utils'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/xorg-x11-xkb-utils-7.4-9.fc14

Comment 19 Hedayat Vatankhah 2010-10-11 10:47:13 UTC
Thanks. It's fixed for me using xorg-x11-xkb-utils-7.4-9.

Comment 20 Zdenek Kabelac 2010-10-15 13:34:31 UTC
I'd like to point out - that my rawhide with xkeyboard-config-2.0-1.fc15.noarch still gives me this warning - so is there going to be clone for rawhide?


gconftool-2 -R /desktop/gnome/peripherals/keyboard/kbd
 layouts = [us,cz	qwerty]
 options = [grp	grp:alts_toggle,terminate	terminate:ctrl_alt_bksp,grp	grp:rwin_switch,grp_led	grp_led:scroll]
 model = 


xprop -root | grep XKB
_XKB_RULES_NAMES_BACKUP(STRING) = "evdev", "evdev", "us", "", "terminate:ctrl_alt_bksp"
_XKB_RULES_NAMES(STRING) = "evdev", "evdev", "us", "", "terminate:ctrl_alt_bksp"

Comment 21 Peter Hutterer 2010-10-17 22:22:23 UTC
(In reply to comment #20)
> I'd like to point out - that my rawhide with xkeyboard-config-2.0-1.fc15.noarch
> still gives me this warning - so is there going to be clone for rawhide?

whoops, sorry. forgot about that one. done.

http://koji.fedoraproject.org/koji/taskinfo?taskID=2539675

Comment 22 Zdenek Kabelac 2010-10-18 11:18:44 UTC
Used as update - and still getting this popup widget activation xkb error.

xprop -root | grep XKB
_XKB_RULES_NAMES_BACKUP(STRING) = "evdev", "evdev", "us", "", "terminate:ctrl_alt_bksp"
_XKB_RULES_NAMES(STRING) = "evdev", "evdev", "us", "", "terminate:ctrl_alt_bksp"


gconftool-2 -R /desktop/gnome/peripherals/keyboard/kbd
 layouts = [us,cz	qwerty]
 options = [grp	grp:alts_toggle,terminate	terminate:ctrl_alt_bksp,grp	grp:rwin_switch,grp_led	grp_led:scroll]
 model = 


rpm -qa | grep org-x11-xkb 
xorg-x11-xkb-utils-7.4-9.fc15.x86_64


(Using todays up-to-date Fedora Rawhide)

Comment 23 Peter Hutterer 2010-10-22 02:27:55 UTC
trying to reproduce, but my g-s-d keeps segfaulting (and the control-center too)

Comment 24 Fedora Update System 2010-10-29 20:40:06 UTC
xorg-x11-xkb-utils-7.4-9.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.