Bug 641936

Summary: spacewalk-create-channel, man page typos
Product: Red Hat Satellite 5 Reporter: Petr Sklenar <psklenar>
Component: UsabilityAssignee: Miroslav Suchý <msuchy>
Status: CLOSED ERRATA QA Contact: Šimon Lukašík <slukasik>
Severity: medium Docs Contact:
Priority: low    
Version: 540CC: ahumbe, cperry, msuchy, slukasik, wesley.schaft
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: spacewalk-remote-utils-1.0.2-12 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-01-05 12:12:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 677498    

Description Petr Sklenar 2010-10-11 14:57:42 UTC
Description of problem:
man typos

Version-Release number of selected component (if applicable):
spacewalk-remote-utils-1.0.2-3.el5sat

How reproducible:
always

Steps to Reproduce:
1. man spacewalk-remote-utils
  
Actual results:
1.
SYNOPSIS
       spaceawlk-create-channel [ options ... ] [ -lUSER ] [ --username=USER ]
2.
EXAMPLES should start on the new line. Now its messed

3.there is './create-channel-update' in usage message.

spacewalk-create-channel --help
usage: ./create-channel-update  -l USER  -s SERVER [-p PASSWORD]  -v VERSION -r RELEASE
                -u UPDATE -a ARCH -e EXTRA  [ -D DATAFILE]  [-c SRCCHAN] -d DESTCHAN [-N DESTNAME]  [-P PARENT]
                [-C | --clear] [-n | --nossl]


Expected results:
no typos, no create-channel-update

Additional info:

Comment 1 Petr Sklenar 2010-10-15 10:29:03 UTC
there is wrong example in man,  please place working one:

# spacewalk-create-channel  -l admin -s `hostname` -d psklenar-rhel6-test -D /usr/share/rhn/channel-data/4-U3-AS-i386
Password: 
Error: data file '4-U3-AS-i386' does not exist

I would recommend to use data file for rhel5 :
/usr/share/rhn/channel-data/5-u5-server-x86_64

Comment 2 Petr Sklenar 2010-10-15 11:29:39 UTC
another typo is:

spacewalk-create-channel  -l admin -s `hostname` -d psklenar-rhel6-test -D /usr/share/rhn/channel-data/5-u1-server-x86_64
Password: 
You have not specified a source channel, we will try to determine it from inputs
Trying with source channel: rhel-x86_64-server-5
Creating channel, psklenar-rhel6-test, with arch x86_64 2857 packages in source file to push.
Pushing 2857 packages, please wait.
Sucessfully pushed 2857 packages out of 2857
^^
s/Sucessfully/Successfully/

Comment 4 Miroslav Suchý 2011-12-08 09:13:23 UTC
Fixed in spacewalk.git in commits:
* d8b72dd 641936 - update example to RHEL6
* af3fef3 641936 - fix typo
* 15c8555 641936 - make man page consistent with --help option
* 86ce45e 641936 - fix typo in man page
* 91ca947 641936 - fix typo in man page

The Example section was fixed some times ago by justin in commits:

d0f25a1198bd2234f2ef9134189dc77b301235ea
fa020bc01749d67c19a0954c52ed7e40d7c458d3

Comment 5 Miroslav Suchý 2011-12-08 09:37:06 UTC
*** Bug 681235 has been marked as a duplicate of this bug. ***

Comment 6 Miroslav Suchý 2011-12-08 09:52:24 UTC
another spacewalk.git commit  753a8dd

Comment 7 Miroslav Suchý 2011-12-08 14:45:32 UTC
spacewalk.git commit f11ef65

Comment 8 Miroslav Suchý 2011-12-09 15:01:52 UTC
cherrypicked to satellite.git as:
* 9af8316 (HEAD, satellite-5.4) 641936 - another typo and fix --help page (cherry picked from commit f11ef65dbac24e94b1200524
* b9407e6 641936 - s|./create-channel-update|create-channel-update| in --help (cherry picked from commit 753a8ddea29a6747d404
* aca5923 641936 - update example to RHEL6 (cherry picked from commit d8b72dd62dba8fbbae2182c098bbc09d6b9e201e)
* 5578d43 641936 - fix typo (cherry picked from commit af3fef390d75a0bb9d5d8b4ac7d6083a8a6b5270)
* 6a1c7c0 641936 - make man page consistent with --help option (cherry picked from commit 15c855572211b8f7aa78ab203817ce2bc77
* c974fc3 man page formatting fix (cherry picked from commit d0f25a1198bd2234f2ef9134189dc77b301235ea)
* 490f059 641936 - fix typo in man page (cherry picked from commit 86ce45e745bfcf0e47a0d705401479e266153725)
* dbd465a 641936 - fix typo in man page (cherry picked from commit 91ca947eb3a2a09ce59ba11403c27f36e4301347)

Comment 10 Šimon Lukašík 2011-12-12 09:21:31 UTC
Flipping back to assigned:

# rpm -q spacewalk-remote-utils
spacewalk-remote-utils-1.0.2-9.el6sat.noarch
# spacewalk-create-channel --help | grep spacewalk-channel-update
Usage: spacewalk-channel-update  -l USER  -s SERVER [-p PASSWORD]  -v VERSION -r RELEASE

There is no such tool as spacewalk-channel-update.

Comment 11 Miroslav Suchý 2011-12-12 10:25:18 UTC
fixed in spacewalk.git:
0da6c20de1d7f7134e7edd0e2743156d47554119
7bfae1dd0ffaa6a58830ea92e665b5c557946858

cherry picked to satellite.git as:
* 7bd4231 641936 - fix grammar in man page (cherry picked from commit 7bfae1dd0ffaa6a58830ea92e665b5c557946858)
* 66f6566 641936 - correct script name in --help output (cherry picked from commit 0da6c20de1d7f7134e7edd0e2743156d47554119)

Comment 13 Šimon Lukašík 2011-12-19 10:02:12 UTC
Moving back to assigned:

(In reply to comment #1)
> there is wrong example in man,  please place working one:
> 

The last example has incorrect option. There should be upper '-P' instead.

# spacewalk-create-channel  -l  admin -s myserver.example.com \
    -v 6 -u u1 -r Server -a x86_64 -e Supplementary \
    -p my-stable-channel -d my-stable-extras
You have not specified a source channel, we will try to determine it from inputs
Trying with source channel: rhel-x86_64-server-supplementary-6
Traceback (most recent call last):
  File "/usr/bin/spacewalk-create-channel", line 454, in <module>
    main()
  File "/usr/bin/spacewalk-create-channel", line 175, in main
    auth = client.auth.login(user, password)
  File "/usr/lib64/python2.6/xmlrpclib.py", line 1199, in __call__
    return self.__send(self.__name, args)
  File "/usr/lib64/python2.6/xmlrpclib.py", line 1489, in __request
    verbose=self.__verbose
  File "/usr/lib64/python2.6/xmlrpclib.py", line 1253, in request
    return self._parse_response(h.getfile(), sock)
  File "/usr/lib64/python2.6/xmlrpclib.py", line 1392, in _parse_response
    return u.close()
  File "/usr/lib64/python2.6/xmlrpclib.py", line 838, in close
    raise Fault(**self._stack[0])
xmlrpclib.Fault: <Fault 2950: 'redstone.xmlrpc.XmlRpcFault: Either the password or username is incorrect.'>

Comment 14 Miroslav Suchý 2011-12-19 13:29:35 UTC
spacewalk.git:
3e8a50bc58093f2bc70be90cbc07af2b58c635c8
cherrypicked to satellite.git as:
29089d59851bce2db395ed144dc553d4c2256bd5

Comment 15 Šimon Lukašík 2012-01-02 10:10:24 UTC
Moving to Verified:

Testing procedure:
 - from comment 0:
    - synopsis in manpage
    - examples in manpage are structured
    - usage
 - from comment 1:
    - all the examples works
 - from comment 2:
    - spelling of successfully
 - from comment 3:
    - upper P for parent_channel
    - examples of update levels

Verified against:
spacewalk-remote-utils-1.0.2-12

Comment 16 errata-xmlrpc 2012-01-05 12:12:29 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0003.html