Bug 642435
Summary: | udev rules broken for pilot-link in f14: can't sync as a user | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Alex Lancaster <alex> | ||||||
Component: | pilot-link | Assignee: | Ivana Varekova <varekova> | ||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | low | ||||||||
Version: | 14 | CC: | alex, bnocera, harald, kevin, triad, varekova | ||||||
Target Milestone: | --- | Keywords: | Reopened | ||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | pilot-link-0.12.5-2.fc14 | Doc Type: | Bug Fix | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | 599639 | Environment: | |||||||
Last Closed: | 2010-11-23 21:48:51 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | 599639 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Alex Lancaster
2010-10-12 22:18:02 UTC
Update: after changing all occurrences of: ENV{ACL_MANAGE}="1" to: ENV{ACL_MANAGE}="0" in the rules file, and then rebooting, synching as a user seems to work now. I will work up a patch. udev/acl hackers: let me know if this is the correct strategy. Well, ENV{ACL_MANAGE}="0" is certainly not correct unless the rules changed again. (In reply to comment #2) > Well, ENV{ACL_MANAGE}="0" is certainly not correct unless the rules changed > again. Well, it definitely makes things work for me, and it appears to have been what was done to fix some of the other bugs. What should the more correct solution be? Just ENV{ACL_MANAGE}!="0" as you suggest in bug 599639 comment #5? Ok.. talked to the udev author... Change ENV{ACL_MANAGE}="1" to ENV{ID_PDA}="1" and remove ENV{ACL_MANAGE}=="1", TAG+="udev-acl" I will release an udev update, which will give all devices with ENV{ID_PDA}=="1" the ACLs. For all the affected libraries: With the current udev in F14, ACL_MANAGE is not used anymore at all, so just TAG+="udev-acl" is likely to work.
> I will release an udev update, which will give all devices with
> ENV{ID_PDA}=="1" the ACLs.
When will that update be issued? F14 will be released in 2 days and ACL setting is broken for many packages.
And are you going to add additional ENV{ID_*} variables for all the libraries that ask for one? Or should they just parasite ID_PDA even if they're not PDAs at all? Or set that udev-acl tag themselves (which is frowned upon)?
Created attachment 457128 [details]
patch for pilot-link part of the issue
Hello Harald, I just put here the patch which you suggests, please when will you fix the udev part? I don't see the update yet. Do you plan to do the same change in rawhide too? Sorry, but that patch cannot be right. > -ENV{ACL_MANAGE}=="1", TAG+="udev-acl" That's the first part of what Harald Hoyer requested in comment #4. > +ENV{ID_PDA}=="1" But that line doesn't make sense. It is a check for ENV{ID_PDA}=="1" (a comparison) without any associated action. Please remove that line. What he actually asked you to do is: > Change ENV{ACL_MANAGE}="1" to ENV{ID_PDA}="1" More precisely: change all instances of ENV{ACL_MANAGE}="1" in the rule file to ENV{ID_PDA}="1", i.e. s/ACL_MANAGE/ID_PDA/g. Created attachment 457176 [details]
fixed patch
sorry fixed
udev-161-6.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/udev-161-6.fc14 upstream patch for udev http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h=d69207c3f20f0af2a5e510515ae5473f4fe54476 (In reply to comment #10) > udev-161-6.fc14 has been submitted as an update for Fedora 14. > https://admin.fedoraproject.org/updates/udev-161-6.fc14 Is the update to udev sufficient to fix this in pilot-link. Or does there also need to be an associated update for pilot-link itself, in addition to the udev update? (In reply to comment #12) > Is the update to udev sufficient to fix this in pilot-link. Or does there also > need to be an associated update for pilot-link itself, in addition to the udev > update? And if so, that build should be added to this update as a single update with both udev + pilot-link before closing this bug. Ivana: I can make the pilot-link build for f14 if you don't have time to backport from f15/rawhide. udev-161-6.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update udev'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/udev-161-6.fc14 (In reply to comment #12) > (In reply to comment #10) > > udev-161-6.fc14 has been submitted as an update for Fedora 14. > > https://admin.fedoraproject.org/updates/udev-161-6.fc14 > > Is the update to udev sufficient to fix this in pilot-link. Or does there also > need to be an associated update for pilot-link itself, in addition to the udev > update? pilot-link would need the patch from comment 9 Thanks a lot Alex, I add it to fc14 version now. pilot-link-0.12.5-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/pilot-link-0.12.5-2.fc14 Fixed in pilot-link-0.12.5-2.fc15. pilot-link-0.12.5-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pilot-link'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/pilot-link-0.12.5-2.fc14 udev-161-6.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. Re-opening until pilot-link update is pushed to stable. pilot-link-0.12.5-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. |